Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(257)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/crash/ChromeMinidumpUploadDelegate.java

Issue 2466443002: Revert of Split MinidumpUploadService into core- and Chrome-implementation. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/crash/ChromeMinidumpUploadDelegate.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/crash/ChromeMinidumpUploadDelegate.java b/chrome/android/java/src/org/chromium/chrome/browser/crash/ChromeMinidumpUploadDelegate.java
deleted file mode 100644
index e0994bde958bb3a00c1fff747bcc7193d2fef776..0000000000000000000000000000000000000000
--- a/chrome/android/java/src/org/chromium/chrome/browser/crash/ChromeMinidumpUploadDelegate.java
+++ /dev/null
@@ -1,71 +0,0 @@
-// Copyright 2016 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-package org.chromium.chrome.browser.crash;
-
-import android.content.Context;
-
-import org.chromium.base.metrics.RecordHistogram;
-import org.chromium.chrome.browser.preferences.ChromePreferenceManager;
-import org.chromium.chrome.browser.preferences.privacy.PrivacyPreferencesManager;
-import org.chromium.components.minidump_uploader.util.CrashReportingPermissionManager;
-import org.chromium.components.minidump_uploader.util.MinidumpUploadDelegate;
-
-/**
- * Chrome-specific implementation of the MinidumpUploadDelegate - providing control over different
- * parts of the Minidump Uploading process.
- */
-public class ChromeMinidumpUploadDelegate implements MinidumpUploadDelegate {
- private static final String TAG = "ChromeMinidumpUploadDelegate";
- /**
- * Histogram related constants.
- */
- private static final String HISTOGRAM_NAME_PREFIX = "Tab.AndroidCrashUpload_";
- private static final int HISTOGRAM_MAX = 2;
- private static final int FAILURE = 0;
- private static final int SUCCESS = 1;
-
- @Override
- public void onSuccessfulUpload(Context context, @ProcessType String crashType) {
- // Increment the count of success by 1 and distinguish between different types of
- // crashes.
- ChromePreferenceManager.getInstance(context).incrementCrashSuccessUploadCount(crashType);
- }
-
- @Override
- public void onMaxedOutUploadFailures(Context context, @ProcessType String crashType) {
- // Increment the count of failure by 1 and distinguish between different types of
- // crashes.
- ChromePreferenceManager.getInstance(context).incrementCrashFailureUploadCount(crashType);
- }
-
- @Override
- public CrashReportingPermissionManager getCrashReportingPermissionManager() {
- return PrivacyPreferencesManager.getInstance();
- }
-
- /**
- * Stores the successes and failures from uploading crash to UMA,
- */
- public static void storeBreakpadUploadStatsInUma(ChromePreferenceManager pref) {
- for (String type : CRASH_TYPES) {
- for (int success = pref.getCrashSuccessUploadCount(type); success > 0; success--) {
- RecordHistogram.recordEnumeratedHistogram(
- HISTOGRAM_NAME_PREFIX + type,
- SUCCESS,
- HISTOGRAM_MAX);
- }
- for (int fail = pref.getCrashFailureUploadCount(type); fail > 0; fail--) {
- RecordHistogram.recordEnumeratedHistogram(
- HISTOGRAM_NAME_PREFIX + type,
- FAILURE,
- HISTOGRAM_MAX);
- }
-
- pref.setCrashSuccessUploadCount(type, 0);
- pref.setCrashFailureUploadCount(type, 0);
- }
- }
-}
-

Powered by Google App Engine
This is Rietveld 408576698