Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(228)

Unified Diff: pkg/analysis_server/tool/instrumentation/page/log_page.dart

Issue 2466403002: Fix bugs in the log viewer (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/analysis_server/tool/instrumentation/log/log.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analysis_server/tool/instrumentation/page/log_page.dart
diff --git a/pkg/analysis_server/tool/instrumentation/page/log_page.dart b/pkg/analysis_server/tool/instrumentation/page/log_page.dart
index ad1194d3f8eac349d1b0605dedcae80c9f52df29..756b2f4a9f157c0fccfaa503b957433720bc8322 100644
--- a/pkg/analysis_server/tool/instrumentation/page/log_page.dart
+++ b/pkg/analysis_server/tool/instrumentation/page/log_page.dart
@@ -225,7 +225,11 @@ function selectEntryGroup(pageStart) {
sink.writeln('</option>');
}
sink.writeln('</select>');
- sink.writeln('Events $pageStart - ${pageEnd - 1} of ${length - 1}');
+ if (length == 0) {
+ sink.writeln('No matching events');
+ } else {
+ sink.writeln('Events $pageStart - ${pageEnd - 1} of $length');
+ }
sink.writeln('</div>');
sink.writeln('<div style="float: right">');
« no previous file with comments | « pkg/analysis_server/tool/instrumentation/log/log.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698