Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Side by Side Diff: pkg/analysis_server/tool/instrumentation/page/log_page.dart

Issue 2466403002: Fix bugs in the log viewer (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « pkg/analysis_server/tool/instrumentation/log/log.dart ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2016, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2016, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 import 'dart:math' as math; 5 import 'dart:math' as math;
6 6
7 import '../log/log.dart'; 7 import '../log/log.dart';
8 import '../server.dart'; 8 import '../server.dart';
9 import 'page_writer.dart'; 9 import 'page_writer.dart';
10 10
(...skipping 207 matching lines...) Expand 10 before | Expand all | Expand 10 after
218 sink.write(group.id); 218 sink.write(group.id);
219 sink.write('"'); 219 sink.write('"');
220 if (group == selectedGroup) { 220 if (group == selectedGroup) {
221 sink.write(' selected'); 221 sink.write(' selected');
222 } 222 }
223 sink.write('>'); 223 sink.write('>');
224 sink.write(group.name); 224 sink.write(group.name);
225 sink.writeln('</option>'); 225 sink.writeln('</option>');
226 } 226 }
227 sink.writeln('</select>'); 227 sink.writeln('</select>');
228 sink.writeln('Events $pageStart - ${pageEnd - 1} of ${length - 1}'); 228 if (length == 0) {
229 sink.writeln('No matching events');
230 } else {
231 sink.writeln('Events $pageStart - ${pageEnd - 1} of $length');
232 }
229 sink.writeln('</div>'); 233 sink.writeln('</div>');
230 234
231 sink.writeln('<div style="float: right">'); 235 sink.writeln('<div style="float: right">');
232 if (pageStart == 0) { 236 if (pageStart == 0) {
233 sink.writeln('<button type="button" disabled><b>&lt;</b></button>'); 237 sink.writeln('<button type="button" disabled><b>&lt;</b></button>');
234 } else { 238 } else {
235 sink.write('<button type="button">'); 239 sink.write('<button type="button">');
236 sink.write( 240 sink.write(
237 '<a href="${WebServer.logPath}?group=${selectedGroup.id}&start=${pageS tart - pageLength}">'); 241 '<a href="${WebServer.logPath}?group=${selectedGroup.id}&start=${pageS tart - pageLength}">');
238 sink.write('<b>&lt;</b>'); 242 sink.write('<b>&lt;</b>');
(...skipping 34 matching lines...) Expand 10 before | Expand all | Expand 10 after
273 void _writeRightColumn(StringSink sink) { 277 void _writeRightColumn(StringSink sink) {
274 // 278 //
275 // Write the header of the column. 279 // Write the header of the column.
276 // 280 //
277 sink.writeln('<div class="columnHeader">'); 281 sink.writeln('<div class="columnHeader">');
278 sink.writeln('<p><b>Entry Details</b></p>'); 282 sink.writeln('<p><b>Entry Details</b></p>');
279 sink.writeln('</div>'); 283 sink.writeln('</div>');
280 sink.writeln('<div id="details"></div>'); 284 sink.writeln('<div id="details"></div>');
281 } 285 }
282 } 286 }
OLDNEW
« no previous file with comments | « pkg/analysis_server/tool/instrumentation/log/log.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698