[WIP Approach 2] Straighten up input method reactivation

Straighten up input method reactivation

On Android, if you move focus from one input form to another, and type a
word immediately, then sometimes the original text gets duplicated.

The reason is that currently onCreateInputConnection() provides incorrect
initial sel start and initial sel end values, and this ended up confusing
the keyboard.

The changes here include:

1) Ignore IME-initiated operations until restart input gets ACKed.

Otherwise, IME operations targeted for the previous input form get applied
to the next input form.

This apply both to cancel composition and focused node change scenarios.
For the deprecating ReplicaInputConnection model, we ignored IME-initiated
operations whenever there was renderer-initiated conflict. We dropped the
logic for ThreadedInputConnection model, but I think it’s useful when
we have to restart input, so partially reviving the logic.

2) Update text input states before restarting input method.

When CancelComposition and FocusedNodeChanged messages are sent in the
middle of IME event guard, input method may see an outdated text input
state when restarting input method. Therefore, we bypass IME event guard
and send them immediately in these cases.

3) One problematic case in 2) is that text input states become garbage
in the middle of a focus change. The reason is that VisibleSelection is
not created in FocusController::setFocusedElement, but in a much later
step.

MouseEventManager::handleMouseFocus()
-> FocusController::setFocusedElement()
-> Document::setFocusedElement()
-> RenderViewImpl::focusedNodeChanged()

However, createVisibleSelection() is called in
MouseEventManager::handleMousePressEvent().

One place we could create VisibleSelection was

Document::setFocusedElement()
-> Element::updateFocusAppearance()

If we call the SelectionBehaviorOnFocus::Restore from MouseEventManager,
selection values can be set correctly.

BUG=650204
add logging

[Changwan Ryu, 2016-11-01 07:42:44]

The CQ bit was checked by changwan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-01 07:42:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Changwan Ryu, 2016-11-01 07:46:10]

Description was changed from

==========
Straighten up input method reactivation

On Android, if you move focus from one input form to another, and type a
word immediately, then sometimes the original text gets duplicated.

The reason is that currently onCreateInputConnection() provides incorrect
initial sel start and initial sel end values, and this ended up confusing
the keyboard.

The changes here include:

1) Ignore IME-initiated operations until restart input gets ACKed.

Otherwise, IME operations targeted for the previous input form get applied
to the next input form.

This apply both to cancel composition and focused node change scenarios.
For the deprecating ReplicaInputConnection model, we ignored IME-initiated
operations whenever there was renderer-initiated conflict. We dropped the
logic for ThreadedInputConnection model, but I think it’s useful when
we have to restart input, so partially reviving the logic.

2) Update text input states before restarting input method.

When CancelComposition and FocusedNodeChanged messages are sent in the
middle of IME event guard, input method may see an outdated text input
state when restarting input method. Therefore, we bypass IME event guard
and send them immediately in these cases.

3) One problematic case in 2) is that text input states become garbage
in the middle of a focus change. The reason is that VisibleSelection is
not created in FocusController::setFocusedElement, but in a much later
step.

MouseEventManager::handleMouseFocus()
-> FocusController::setFocusedElement()
-> Document::setFocusedElement()
-> RenderViewImpl::focusedNodeChanged()

However, createVisibleSelection() is called in
MouseEventManager::handleMousePressEvent().

One place we could create VisibleSelection was

Document::setFocusedElement()
-> Element::updateFocusAppearance()

If we call the SelectionBehaviorOnFocus::Restore, selection values
are set correctly.

BUG=650204

add logging
==========

to

==========
Straighten up input method reactivation

On Android, if you move focus from one input form to another, and type a
word immediately, then sometimes the original text gets duplicated.

The reason is that currently onCreateInputConnection() provides incorrect
initial sel start and initial sel end values, and this ended up confusing
the keyboard.

The changes here include:

1) Ignore IME-initiated operations until restart input gets ACKed.

Otherwise, IME operations targeted for the previous input form get applied
to the next input form.

This apply both to cancel composition and focused node change scenarios.
For the deprecating ReplicaInputConnection model, we ignored IME-initiated
operations whenever there was renderer-initiated conflict. We dropped the
logic for ThreadedInputConnection model, but I think it’s useful when
we have to restart input, so partially reviving the logic.

2) Update text input states before restarting input method.

When CancelComposition and FocusedNodeChanged messages are sent in the
middle of IME event guard, input method may see an outdated text input
state when restarting input method. Therefore, we bypass IME event guard
and send them immediately in these cases.

3) One problematic case in 2) is that text input states become garbage
in the middle of a focus change. The reason is that VisibleSelection is
not created in FocusController::setFocusedElement, but in a much later
step.

MouseEventManager::handleMouseFocus()
-> FocusController::setFocusedElement()
-> Document::setFocusedElement()
-> RenderViewImpl::focusedNodeChanged()

However, createVisibleSelection() is called in
MouseEventManager::handleMousePressEvent().

One place we could create VisibleSelection was

Document::setFocusedElement()
-> Element::updateFocusAppearance()

If we call the SelectionBehaviorOnFocus::Restore, selection values
are set correctly.

BUG=650204

add logging
==========

[Changwan Ryu, 2016-11-01 08:08:05]

Description was changed from

==========
Straighten up input method reactivation

On Android, if you move focus from one input form to another, and type a
word immediately, then sometimes the original text gets duplicated.

The reason is that currently onCreateInputConnection() provides incorrect
initial sel start and initial sel end values, and this ended up confusing
the keyboard.

The changes here include:

1) Ignore IME-initiated operations until restart input gets ACKed.

Otherwise, IME operations targeted for the previous input form get applied
to the next input form.

This apply both to cancel composition and focused node change scenarios.
For the deprecating ReplicaInputConnection model, we ignored IME-initiated
operations whenever there was renderer-initiated conflict. We dropped the
logic for ThreadedInputConnection model, but I think it’s useful when
we have to restart input, so partially reviving the logic.

2) Update text input states before restarting input method.

When CancelComposition and FocusedNodeChanged messages are sent in the
middle of IME event guard, input method may see an outdated text input
state when restarting input method. Therefore, we bypass IME event guard
and send them immediately in these cases.

3) One problematic case in 2) is that text input states become garbage
in the middle of a focus change. The reason is that VisibleSelection is
not created in FocusController::setFocusedElement, but in a much later
step.

MouseEventManager::handleMouseFocus()
-> FocusController::setFocusedElement()
-> Document::setFocusedElement()
-> RenderViewImpl::focusedNodeChanged()

However, createVisibleSelection() is called in
MouseEventManager::handleMousePressEvent().

One place we could create VisibleSelection was

Document::setFocusedElement()
-> Element::updateFocusAppearance()

If we call the SelectionBehaviorOnFocus::Restore, selection values
are set correctly.

BUG=650204

add logging
==========

to

==========
Straighten up input method reactivation

On Android, if you move focus from one input form to another, and type a
word immediately, then sometimes the original text gets duplicated.

The reason is that currently onCreateInputConnection() provides incorrect
initial sel start and initial sel end values, and this ended up confusing
the keyboard.

The changes here include:

1) Ignore IME-initiated operations until restart input gets ACKed.

Otherwise, IME operations targeted for the previous input form get applied
to the next input form.

This apply both to cancel composition and focused node change scenarios.
For the deprecating ReplicaInputConnection model, we ignored IME-initiated
operations whenever there was renderer-initiated conflict. We dropped the
logic for ThreadedInputConnection model, but I think it’s useful when
we have to restart input, so partially reviving the logic.

2) Update text input states before restarting input method.

When CancelComposition and FocusedNodeChanged messages are sent in the
middle of IME event guard, input method may see an outdated text input
state when restarting input method. Therefore, we bypass IME event guard
and send them immediately in these cases.

3) One problematic case in 2) is that text input states become garbage
in the middle of a focus change. The reason is that VisibleSelection is
not created in FocusController::setFocusedElement, but in a much later
step.

MouseEventManager::handleMouseFocus()
-> FocusController::setFocusedElement()
-> Document::setFocusedElement()
-> RenderViewImpl::focusedNodeChanged()

However, createVisibleSelection() is called in
MouseEventManager::handleMousePressEvent().

One place we could create VisibleSelection was

Document::setFocusedElement()
-> Element::updateFocusAppearance()

If we call the SelectionBehaviorOnFocus::Restore from MouseEventManager,
selection values can be set correctly.

BUG=650204

add logging
==========

[commit-bot: I haz the power, 2016-11-01 08:27:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-01 08:27:28]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)