content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java - Issue 2466283002: [WIP Approach 2] Straighten up input method reactivation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java

Issue 2466283002: [WIP Approach 2] Straighten up input method reactivation

Patch Set: Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/public/android/java/src/org/chromium/content/browser/input/ThreadedInputConnectionFactory.java ('k') | content/renderer/render_view_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java

diff --git a/content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java b/content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java

index 44402ca53d71353a66fd6b069de815a7153f0fd5..d9851a103134d17c79ba90fae74927920aacd3f6 100644

--- a/content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java

+++ b/content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java

@@ -117,7 +117,7 @@ public class ImeTest extends ContentShellTestBase {

assertEquals(0, mConnectionFactory.getOutAttrs().initialSelStart);

assertEquals(0, mConnectionFactory.getOutAttrs().initialSelEnd);

- waitForEventLogs("selectionchange");

+ // waitForEventLogs("selectionchange");

clearEventLogs();

resetAllStates();

@@ -464,18 +464,14 @@ public class ImeTest extends ContentShellTestBase {

waitForKeyboardStates(2, 1, 3, new Integer[] {TextInputType.NUMBER, TextInputType.NUMBER});

focusElement("input_text");

- // showSoftInput() on input_text. restartInput() on input_number1 due to focus change,

- // and restartInput() on input_text later.

- // TODO(changwan): reduce unnecessary restart input.

- waitForKeyboardStates(3, 1, 5, new Integer[] {

- TextInputType.NUMBER, TextInputType.NUMBER, TextInputType.NUMBER,

- TextInputType.TEXT});

+ // showSoftInput() on input_text. restartInput() on input_text.

+ waitForKeyboardStates(3, 1, 4, new Integer[] {

+ TextInputType.NUMBER, TextInputType.NUMBER, TextInputType.TEXT});

focusElement("input_radio", false);

// hideSoftInput(), restartInput()

- waitForKeyboardStates(3, 2, 6, new Integer[] {

- TextInputType.NUMBER, TextInputType.NUMBER, TextInputType.NUMBER,

- TextInputType.TEXT});

+ waitForKeyboardStates(3, 2, 5, new Integer[] {

+ TextInputType.NUMBER, TextInputType.NUMBER, TextInputType.TEXT});

}

private void assertTextsAroundCursor(