Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(320)

Issue 2466263007: Add gdb macro to find assertion scopes on the stack. (Closed)

Created:
4 years, 1 month ago by Yang
Modified:
4 years, 1 month ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Add gdb macro to find assertion scopes on the stack. This is how it would look like. (gdb) bta [1 ] V8_Fatal ../../src/base/logging.cc:67 [2 ] v8::internal::Heap::AllocateRaw ../../src/heap/heap-inl.h:298 [3 ] v8::internal::Heap::AllocateHeapNumber ../../src/heap/heap.cc:2432 [4 ] v8::internal::Factory::NewHeapNumber ../../src/factory.cc:1253 [5 ] v8::internal::Factory::NewNumber ../../src/factory.cc:1228 [6 ] v8::internal::__RT_impl_Runtime_ConstructDouble ../../src/runtime/runtime-test.cc:32 -> Allow HEAP_ALLOCATION (yes_gc) -> Disallow HEAP_ALLOCATION (no_gc) [7 ] v8::internal::Runtime_ConstructDouble ../../src/runtime/runtime-test.cc:24 R=jochen@chromium.org Committed: https://crrev.com/6ab61037f3013bf5820bde9d01ed8a961c06a158 Cr-Commit-Position: refs/heads/master@{#40748}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -0 lines) Patch
M tools/gdbinit View 1 chunk +26 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Yang
please take a look
4 years, 1 month ago (2016-11-03 14:25:39 UTC) #1
jochen (gone - plz use gerrit)
lgtm
4 years, 1 month ago (2016-11-03 15:09:36 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2466263007/1
4 years, 1 month ago (2016-11-04 06:55:51 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-04 07:27:45 UTC) #5
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:21:55 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6ab61037f3013bf5820bde9d01ed8a961c06a158
Cr-Commit-Position: refs/heads/master@{#40748}

Powered by Google App Engine
This is Rietveld 408576698