Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(485)

Issue 246623004: List removed (non-whitelisted) resources when repacking. (Closed)

Created:
6 years, 8 months ago by Lei Zhang
Modified:
6 years, 8 months ago
Reviewers:
newt (away)
CC:
grit-developer_googlegroups.com, aurimas (slooooooooow), Nico
Visibility:
Public.

Description

List removed (non-whitelisted) resources when repacking. R=newt@chromium.org Committed: https://code.google.com/p/grit-i18n/source/detail?r=167

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M grit/format/data_pack.py View 2 chunks +5 lines, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
Lei Zhang
6 years, 8 months ago (2014-04-22 05:06:26 UTC) #1
newt (away)
Code looks good. What's the reason for landing this?
6 years, 8 months ago (2014-04-22 17:53:15 UTC) #2
Lei Zhang
On 2014/04/22 17:53:15, newt wrote: > Code looks good. What's the reason for landing this? ...
6 years, 8 months ago (2014-04-22 18:15:43 UTC) #3
newt (away)
Gotcha. lgtm if we're OK with the additional build spew.
6 years, 8 months ago (2014-04-22 18:25:21 UTC) #4
Lei Zhang
On 2014/04/22 18:25:21, newt wrote: > Gotcha. lgtm if we're OK with the additional build ...
6 years, 8 months ago (2014-04-22 19:03:28 UTC) #5
newt (away)
On 2014/04/22 19:03:28, Lei Zhang wrote: > On 2014/04/22 18:25:21, newt wrote: > > Gotcha. ...
6 years, 8 months ago (2014-04-22 19:11:13 UTC) #6
Lei Zhang
On 2014/04/22 19:11:13, newt wrote: > On 2014/04/22 19:03:28, Lei Zhang wrote: > > On ...
6 years, 8 months ago (2014-04-22 19:18:53 UTC) #7
newt (away)
6 years, 8 months ago (2014-04-22 20:54:53 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 manually as r167 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698