Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Unified Diff: grit/format/data_pack.py

Issue 246623004: List removed (non-whitelisted) resources when repacking. (Closed) Base URL: http://grit-i18n.googlecode.com/svn/trunk/
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: grit/format/data_pack.py
===================================================================
--- grit/format/data_pack.py (revision 160)
+++ grit/format/data_pack.py (working copy)
@@ -137,7 +137,7 @@
Args:
inputs: a list of data pack strings that need to be combined.
- whitelist: a list of resource IDs that should be kep in the output string
+ whitelist: a list of resource IDs that should be kept in the output string
or None to include all resources.
Returns:
@@ -168,6 +168,10 @@
for key in content.resources.keys()
if key in whitelist])
resources.update(whitelisted_resources)
+ removed_keys = [key for key in content.resources.keys()
+ if key not in whitelist]
+ for key in removed_keys:
+ print 'RePackFromDataPackStrings Removed Key:', key
else:
resources.update(content.resources)
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698