Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(303)

Unified Diff: third_party/WebKit/LayoutTests/bluetooth/getDescriptors/get-same-Descriptors.html

Issue 2466223002: Implement WebBluetooth getDescriptor[s] (Closed)
Patch Set: Ensure that we throw a kGattServerNotConnected error if getDescriptor[s] is called while not connec… Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/bluetooth/getDescriptors/get-same-Descriptors.html
diff --git a/third_party/WebKit/LayoutTests/bluetooth/notifications/concurrent-starts.html b/third_party/WebKit/LayoutTests/bluetooth/getDescriptors/get-same-Descriptors.html
similarity index 52%
copy from third_party/WebKit/LayoutTests/bluetooth/notifications/concurrent-starts.html
copy to third_party/WebKit/LayoutTests/bluetooth/getDescriptors/get-same-Descriptors.html
index 5f9b657fbeb31458543a171eb9f5b9f40df7b1d2..d939cd7d1b6a738d9eddbf85548f837006c5284b 100644
--- a/third_party/WebKit/LayoutTests/bluetooth/notifications/concurrent-starts.html
+++ b/third_party/WebKit/LayoutTests/bluetooth/getDescriptors/get-same-Descriptors.html
@@ -4,18 +4,24 @@
<script src="../../resources/bluetooth/bluetooth-helpers.js"></script>
<script>
'use strict';
+
promise_test(() => {
return setBluetoothFakeAdapter('HeartRateAdapter')
.then(() => requestDeviceWithKeyDown({
- filters: [{services: ['heart_rate']}]}))
+ filters: [{services: ['heart_rate']}],
+ optionalServices: ['generic_access']}))
.then(device => device.gatt.connect())
.then(gattServer => gattServer.getPrimaryService('heart_rate'))
.then(service => service.getCharacteristic('heart_rate_measurement'))
.then(characteristic => Promise.all([
- characteristic.startNotifications(),
- characteristic.startNotifications(),
- characteristic.startNotifications()]));
- // TODO(ortuno): Assert that notifications are active.
- // http://crbug.com/600762
-}, 'Multiple starts in a row.');
+ characteristic.getDescriptors(user_description.alias),
+ characteristic.getDescriptors(user_description.alias)])
+ .then(descriptors => {
+ for (var i = 1; i < descriptors.length; i++) {
+ assert_not_equals(
+ descriptors[0], descriptors[i],
+ 'Should return the same descriptor as the first call.');
+ }
+ }))
+}, 'Calls to get the same descriptor should return the same object.');
</script>

Powered by Google App Engine
This is Rietveld 408576698