third_party/WebKit/LayoutTests/bluetooth/characteristic/getDescriptors/gen-descriptor-invalid-name.html - Issue 2466223002: Implement WebBluetooth getDescriptor[s]

Unified Diff: third_party/WebKit/LayoutTests/bluetooth/characteristic/getDescriptors/gen-descriptor-invalid-name.html

Issue 2466223002: Implement WebBluetooth getDescriptor[s] (Closed)

Patch Set: rebase to master Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

« third_party/WebKit/LayoutTests/bluetooth/characteristic/getDescriptors/blocklisted-descriptors-not-present.html ('K') | « third_party/WebKit/LayoutTests/bluetooth/characteristic/getDescriptors/gen-descriptor-garbage-collection-ran-during-success-with-uuid.html ('k') | third_party/WebKit/LayoutTests/bluetooth/characteristic/getDescriptors/gen-descriptor-invalid-name-with-uuid.html » ('j') | third_party/WebKit/LayoutTests/bluetooth/script-tests/characteristic/descriptor-blocklisted.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/bluetooth/characteristic/getDescriptors/gen-descriptor-invalid-name.html

diff --git a/third_party/WebKit/LayoutTests/bluetooth/characteristic/getDescriptors/gen-descriptor-invalid-name.html b/third_party/WebKit/LayoutTests/bluetooth/characteristic/getDescriptors/gen-descriptor-invalid-name.html

new file mode 100644

index 0000000000000000000000000000000000000000..ef957fca428edafd61400b55649bd8c2bfddbc09

--- /dev/null

+++ b/third_party/WebKit/LayoutTests/bluetooth/characteristic/getDescriptors/gen-descriptor-invalid-name.html

@@ -0,0 +1,36 @@

+

+<!DOCTYPE html>

+<script src="../../../resources/testharness.js"></script>

+<script src="../../../resources/testharnessreport.js"></script>

+<script src="../../../resources/bluetooth/bluetooth-helpers.js"></script>

+<script>

+'use strict';

+promise_test(() => {

+ let promise;

+ return setBluetoothFakeAdapter('DisconnectingHealthThermometerAdapter')

+ .then(() => requestDeviceWithKeyDown({

+ filters: [{services: ['health_thermometer']}]}))

+ .then(device => device.gatt.connect())

+ .then(gattServer => gattServer.getPrimaryService('health_thermometer'))

+ .then(service => service.getCharacteristic('measurement_interval'))

+ .then(characteristic => {

+ return assert_promise_rejects_with_message(

+ characteristic.getDescriptors('invalid-name'),

+ new DOMException(

+ 'Failed to execute \'getDescriptors\' on ' +

+ '\'BluetoothRemoteGATTCharacteristic\': Invalid Descriptor name: ' +

+ '\'invalid-name\'. ' +

+ 'It must be a valid UUID alias (e.g. 0x1234), ' +

+ 'UUID (lowercase hex characters e.g. ' +

+ '\'00001234-0000-1000-8000-00805f9b34fb\'), ' +

+ 'or recognized standard name from ' +

+ 'https://developer.bluetooth.org/gatt/descriptors/' +

+ 'Pages/DescriptorsHomePage.aspx' +

+ ' e.g. \'gatt.characteristic_presentation_format\'.',

+ 'TypeError'));

+ })

+}, 'Test to ensure getDescriptors throws when called with an invalid name. ' +

+ 'Should not crash.');

ortuno 2016/12/08 05:42:51 I mean it's technically correct :P but also not sp

dougt 2016/12/08 08:35:58 Done.

+</script>