third_party/WebKit/LayoutTests/bluetooth/characteristic/getDescriptors/gen-descriptor-invalid-name.html - Issue 2466223002: Implement WebBluetooth getDescriptor[s]

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/bluetooth/characteristic/getDescriptors/gen-descriptor-invalid-name.html

Issue 2466223002: Implement WebBluetooth getDescriptor[s] (Closed)

Patch Set: rebase to master Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« third_party/WebKit/LayoutTests/bluetooth/characteristic/getDescriptors/blocklisted-descriptors-not-present.html ('K') | « third_party/WebKit/LayoutTests/bluetooth/characteristic/getDescriptors/gen-descriptor-garbage-collection-ran-during-success-with-uuid.html ('k') | third_party/WebKit/LayoutTests/bluetooth/characteristic/getDescriptors/gen-descriptor-invalid-name-with-uuid.html » ('j') | third_party/WebKit/LayoutTests/bluetooth/script-tests/characteristic/descriptor-blocklisted.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!-- Generated by //third_party/WebKit/LayoutTests/bluetooth/generate.py -->

	2 <!DOCTYPE html>

	3 <script src="../../../resources/testharness.js"></script>

	4 <script src="../../../resources/testharnessreport.js"></script>

	5 <script src="../../../resources/bluetooth/bluetooth-helpers.js"></script>

	6 <script>

	7 'use strict';

	8 promise_test(() => {

	9 let promise;

	10 return setBluetoothFakeAdapter('DisconnectingHealthThermometerAdapter')

	11 .then(() => requestDeviceWithKeyDown({

	12 filters: [{services: ['health_thermometer']}]}))

	13 .then(device => device.gatt.connect())

	14 .then(gattServer => gattServer.getPrimaryService('health_thermometer'))

	15 .then(service => service.getCharacteristic('measurement_interval'))

	16 .then(characteristic => {

	17 return assert_promise_rejects_with_message(

	18 characteristic.getDescriptors('invalid-name'),

	19 new DOMException(

	20 'Failed to execute \'getDescriptors\' on ' +

	21 '\'BluetoothRemoteGATTCharacteristic\': Invalid Descriptor nam e: ' +

	22 '\'invalid-name\'. ' +

	23 'It must be a valid UUID alias (e.g. 0x1234), ' +

	24 'UUID (lowercase hex characters e.g. ' +

	25 '\'00001234-0000-1000-8000-00805f9b34fb\'), ' +

	26 'or recognized standard name from ' +

	27 'https://developer.bluetooth.org/gatt/descriptors/' +

	28 'Pages/DescriptorsHomePage.aspx' +

	29 ' e.g. \'gatt.characteristic_presentation_format\'.',

	30 'TypeError'));

	31

	32 })

	33 }, 'Test to ensure getDescriptors throws when called with an invalid name. ' +

	34 'Should not crash.');
	ortuno 2016/12/08 05:42:51 I mean it's technically correct :P but also not sp I mean it's technically correct :P but also not specific to this test. Just remove. dougt 2016/12/08 08:35:58 Done. Show quoted text On 2016/12/08 05:42:51, ortuno wrote: > I mean it's technically correct :P but also not specific to this test. Just > remove. Done.
	35

	36 </script>

OLD	NEW