Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 2466203002: Fix founding difference in pdfium_test on AdobeCMYK_to_sRGB (Closed)

Created:
4 years, 1 month ago by brucedawson
Modified:
4 years, 1 month ago
Reviewers:
_cary, dsinclair, chengx
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Fix founding difference in pdfium_test on AdobeCMYK_to_sRGB An optimization to speed up float-to-int rounding caused a different result for one input value. This tweaks the conversion constant so that the results are identical across the entire valid range, and adds a test that checks the part of the range that is most sensitive to errors. BUG=pdfium:624 Committed: https://pdfium.googlesource.com/pdfium/+/fcb1728c35f97a67fa0297f12bb13d3cafb01fe1

Patch Set 1 #

Patch Set 2 : Fixing comments and types #

Patch Set 3 : Remove blank line #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -11 lines) Patch
M core/fxcodec/codec/fx_codec_icc.cpp View 1 2 1 chunk +11 lines, -11 lines 0 comments Download
M core/fxcodec/codec/fx_codec_jpx_unittest.cpp View 1 1 chunk +23 lines, -0 lines 0 comments Download

Messages

Total messages: 20 (14 generated)
brucedawson
This fixes the rounding bug. PTAL.
4 years, 1 month ago (2016-11-01 17:51:25 UTC) #10
brucedawson
Adding a bonus extra reviewer...
4 years, 1 month ago (2016-11-01 17:53:34 UTC) #12
_cary
lgtm
4 years, 1 month ago (2016-11-01 18:18:16 UTC) #15
dsinclair
lgtm
4 years, 1 month ago (2016-11-01 18:22:07 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2466203002/40001
4 years, 1 month ago (2016-11-01 18:22:12 UTC) #18
commit-bot: I haz the power
4 years, 1 month ago (2016-11-01 18:22:29 UTC) #20
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://pdfium.googlesource.com/pdfium/+/fcb1728c35f97a67fa0297f12bb13d3cafb0...

Powered by Google App Engine
This is Rietveld 408576698