Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(592)

Unified Diff: third_party/WebKit/Source/devtools/front_end/profiler/HeapSnapshotGridNodes.js

Issue 2466123002: DevTools: reformat front-end code to match chromium style. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/profiler/HeapSnapshotGridNodes.js
diff --git a/third_party/WebKit/Source/devtools/front_end/profiler/HeapSnapshotGridNodes.js b/third_party/WebKit/Source/devtools/front_end/profiler/HeapSnapshotGridNodes.js
index 48e34a949aa2c2bed6e50664ef64a424a49fc456..317927a93670b989f715fd8e11aa8f23d88cdee7 100644
--- a/third_party/WebKit/Source/devtools/front_end/profiler/HeapSnapshotGridNodes.js
+++ b/third_party/WebKit/Source/devtools/front_end/profiler/HeapSnapshotGridNodes.js
@@ -51,6 +51,7 @@ WebInspector.HeapSnapshotGridNode = function(tree, hasChildren)
* @type {?WebInspector.HeapSnapshotGridNode.ChildrenProvider}
*/
this._providerObject = null;
+ this._reachableFromWindow = false;
};
/** @enum {symbol} */
@@ -177,9 +178,12 @@ WebInspector.HeapSnapshotGridNode.prototype = {
node.dispose();
},
- _reachableFromWindow: false,
-
- queryObjectContent: function(callback)
+ /**
+ * @param {!WebInspector.Target} target
+ * @param {function(!WebInspector.RemoteObject)} callback
+ * @param {string} objectGroupName
+ */
+ queryObjectContent: function(target, callback, objectGroupName)
{
},
@@ -270,7 +274,10 @@ WebInspector.HeapSnapshotGridNode.prototype = {
return cell;
},
- populate: function(event)
+ /**
+ * @override
+ */
+ populate: function()
{
if (this._populated)
return;
@@ -628,6 +635,7 @@ WebInspector.HeapSnapshotGenericObjectNode.prototype = {
},
/**
+ * @override
* @param {!WebInspector.Target} target
* @param {function(!WebInspector.RemoteObject)} callback
* @param {string} objectGroupName
@@ -791,6 +799,9 @@ WebInspector.HeapSnapshotObjectNode.prototype = {
return WebInspector.HeapSnapshotGridNode.createComparator(sortFields);
},
+ /**
+ * @override
+ */
_prefixObjectCell: function(div)
{
var name = this._referenceName || "(empty)";
@@ -876,6 +887,9 @@ WebInspector.HeapSnapshotRetainingObjectNode.prototype = {
return " in ";
},
+ /**
+ * @override
+ */
expand: function()
{
this._expandRetainersChain(20);
@@ -900,7 +914,7 @@ WebInspector.HeapSnapshotRetainingObjectNode.prototype = {
this.populate();
return;
}
- WebInspector.HeapSnapshotGenericObjectNode.prototype.expand.call(this);
+ WebInspector.HeapSnapshotObjectNode.prototype.expand.call(this);
if (--maxExpandLevels > 0 && this.children.length > 0) {
var retainer = this.children[0];
if (retainer._distance > 1) {
@@ -1455,6 +1469,9 @@ WebInspector.AllocationGridNode = function(dataGrid, data)
};
WebInspector.AllocationGridNode.prototype = {
+ /**
+ * @override
+ */
populate: function()
{
if (this._populated)

Powered by Google App Engine
This is Rietveld 408576698