Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(234)

Unified Diff: third_party/WebKit/Source/devtools/front_end/heap_snapshot_worker/HeapSnapshot.js

Issue 2466123002: DevTools: reformat front-end code to match chromium style. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/heap_snapshot_worker/HeapSnapshot.js
diff --git a/third_party/WebKit/Source/devtools/front_end/heap_snapshot_worker/HeapSnapshot.js b/third_party/WebKit/Source/devtools/front_end/heap_snapshot_worker/HeapSnapshot.js
index 3f1cf1c710ac1ee9afeeac93e45dee5df1d0c5a0..f7b136d65bcb4d5d4ddd43ba2bb7e00f5dbfba95 100644
--- a/third_party/WebKit/Source/devtools/front_end/heap_snapshot_worker/HeapSnapshot.js
+++ b/third_party/WebKit/Source/devtools/front_end/heap_snapshot_worker/HeapSnapshot.js
@@ -113,7 +113,7 @@ WebInspector.HeapSnapshotEdge.prototype = {
*/
type: function()
{
- return this._snapshot._edgeTypes[this._type()];
+ return this._snapshot._edgeTypes[this.rawType()];
},
/**
@@ -134,7 +134,11 @@ WebInspector.HeapSnapshotEdge.prototype = {
return new WebInspector.HeapSnapshotCommon.Edge(this.name(), this.node().serialize(), this.type(), this.edgeIndex);
},
- _type: function()
+ /**
+ * @protected
+ * @return {number}
+ */
+ rawType: function()
{
return this._edges[this.edgeIndex + this._snapshot._edgeTypeOffset];
}
@@ -586,7 +590,7 @@ WebInspector.HeapSnapshotNode.prototype = {
*/
type: function()
{
- return this._snapshot._nodeTypes[this._type()];
+ return this._snapshot._nodeTypes[this.rawType()];
},
/**
@@ -658,9 +662,10 @@ WebInspector.HeapSnapshotNode.prototype = {
},
/**
+ * @protected
* @return {number}
*/
- _type: function()
+ rawType: function()
{
var snapshot = this._snapshot;
return snapshot.nodes[this.nodeIndex + snapshot._nodeTypeOffset];
@@ -1001,7 +1006,7 @@ WebInspector.HeapSnapshot.prototype = {
this._progress.updateStatus("Building retainers\u2026");
this._buildRetainers();
this._progress.updateStatus("Calculating node flags\u2026");
- this._calculateFlags();
+ this.calculateFlags();
this._progress.updateStatus("Calculating distances\u2026");
this.calculateDistances();
this._progress.updateStatus("Building postorder index\u2026");
@@ -1986,7 +1991,10 @@ WebInspector.HeapSnapshot.prototype = {
return this._samples;
},
- _calculateFlags: function()
+ /**
+ * @protected
+ */
+ calculateFlags: function()
{
throw new Error("Not implemented");
},

Powered by Google App Engine
This is Rietveld 408576698