Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(331)

Unified Diff: third_party/WebKit/Source/devtools/front_end/heap_snapshot_worker/JSHeapSnapshot.js

Issue 2466123002: DevTools: reformat front-end code to match chromium style. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/heap_snapshot_worker/JSHeapSnapshot.js
diff --git a/third_party/WebKit/Source/devtools/front_end/heap_snapshot_worker/JSHeapSnapshot.js b/third_party/WebKit/Source/devtools/front_end/heap_snapshot_worker/JSHeapSnapshot.js
index a39ca70e3197893ff6a40d66221f89a661c62984..3b1b6db14c1f94e053c4232a686ece8420dd4c19 100644
--- a/third_party/WebKit/Source/devtools/front_end/heap_snapshot_worker/JSHeapSnapshot.js
+++ b/third_party/WebKit/Source/devtools/front_end/heap_snapshot_worker/JSHeapSnapshot.js
@@ -122,7 +122,10 @@ WebInspector.JSHeapSnapshot.prototype = {
return filter;
},
- _calculateFlags: function()
+ /**
+ * @override
+ */
+ calculateFlags: function()
{
this._flags = new Uint32Array(this.nodeCount);
this._markDetachedDOMTreeNodes();
@@ -130,6 +133,9 @@ WebInspector.JSHeapSnapshot.prototype = {
this._markPageOwnedNodes();
},
+ /**
+ * @override
+ */
calculateDistances: function()
{
/**
@@ -234,6 +240,7 @@ WebInspector.JSHeapSnapshot.prototype = {
},
/**
+ * @override
* @return {?{map: !Uint32Array, flag: number}}
*/
userObjectsMapAndFlag: function()
@@ -497,7 +504,10 @@ WebInspector.JSHeapSnapshotNode.prototype = {
/**
* @return {string}
*/
- rawName: WebInspector.HeapSnapshotNode.prototype.name,
+ rawName: function()
+ {
+ return WebInspector.HeapSnapshotNode.prototype.name.call(this);
+ },
/**
* @override
@@ -506,7 +516,7 @@ WebInspector.JSHeapSnapshotNode.prototype = {
name: function()
{
var snapshot = this._snapshot;
- if (this._type() === snapshot._nodeConsStringType) {
+ if (this.rawType() === snapshot._nodeConsStringType) {
var string = snapshot._lazyStringCache[this.nodeIndex];
if (typeof string === "undefined") {
string = this._consStringName();
@@ -616,7 +626,7 @@ WebInspector.JSHeapSnapshotNode.prototype = {
*/
isHidden: function()
{
- return this._type() === this._snapshot._nodeHiddenType;
+ return this.rawType() === this._snapshot._nodeHiddenType;
},
/**
@@ -624,7 +634,7 @@ WebInspector.JSHeapSnapshotNode.prototype = {
*/
isArray: function()
{
- return this._type() === this._snapshot._nodeArrayType;
+ return this.rawType() === this._snapshot._nodeArrayType;
},
/**
@@ -632,7 +642,7 @@ WebInspector.JSHeapSnapshotNode.prototype = {
*/
isSynthetic: function()
{
- return this._type() === this._snapshot._nodeSyntheticType;
+ return this.rawType() === this._snapshot._nodeSyntheticType;
},
/**
@@ -707,7 +717,7 @@ WebInspector.JSHeapSnapshotEdge.prototype = {
*/
isElement: function()
{
- return this._type() === this._snapshot._edgeElementType;
+ return this.rawType() === this._snapshot._edgeElementType;
},
/**
@@ -715,7 +725,7 @@ WebInspector.JSHeapSnapshotEdge.prototype = {
*/
isHidden: function()
{
- return this._type() === this._snapshot._edgeHiddenType;
+ return this.rawType() === this._snapshot._edgeHiddenType;
},
/**
@@ -723,7 +733,7 @@ WebInspector.JSHeapSnapshotEdge.prototype = {
*/
isWeak: function()
{
- return this._type() === this._snapshot._edgeWeakType;
+ return this.rawType() === this._snapshot._edgeWeakType;
},
/**
@@ -731,7 +741,7 @@ WebInspector.JSHeapSnapshotEdge.prototype = {
*/
isInternal: function()
{
- return this._type() === this._snapshot._edgeInternalType;
+ return this.rawType() === this._snapshot._edgeInternalType;
},
/**
@@ -739,7 +749,7 @@ WebInspector.JSHeapSnapshotEdge.prototype = {
*/
isInvisible: function()
{
- return this._type() === this._snapshot._edgeInvisibleType;
+ return this.rawType() === this._snapshot._edgeInvisibleType;
},
/**
@@ -747,7 +757,7 @@ WebInspector.JSHeapSnapshotEdge.prototype = {
*/
isShortcut: function()
{
- return this._type() === this._snapshot._edgeShortcutType;
+ return this.rawType() === this._snapshot._edgeShortcutType;
},
/**
@@ -794,7 +804,7 @@ WebInspector.JSHeapSnapshotEdge.prototype = {
*/
_hasStringName: function()
{
- var type = this._type();
+ var type = this.rawType();
var snapshot = this._snapshot;
return type !== snapshot._edgeElementType && type !== snapshot._edgeHiddenType;
},
@@ -816,9 +826,10 @@ WebInspector.JSHeapSnapshotEdge.prototype = {
},
/**
+ * @override
* @return {number}
*/
- _type: function()
+ rawType: function()
{
return this._edges[this.edgeIndex + this._snapshot._edgeTypeOffset];
},

Powered by Google App Engine
This is Rietveld 408576698