Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Issue 2466093002: Domain Reliability: Add more upload-related histograms. (Closed)

Created:
4 years, 1 month ago by Julia Tuttle
Modified:
4 years, 1 month ago
CC:
chromium-reviews, asvitkine+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Domain Reliability: Add more upload-related histograms. Add some more histograms characterizing the frequency and distribution of uploads, so we can see how well the backoff behavior works in production. BUG=660989 Committed: https://crrev.com/dd99ca65f3c77b2de0d8d5a43c77d706152422c8 Cr-Commit-Position: refs/heads/master@{#429053}

Patch Set 1 #

Total comments: 4

Patch Set 2 : A couple of tweaks. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+90 lines, -5 lines) Patch
M components/domain_reliability/context.h View 2 chunks +6 lines, -1 line 0 comments Download
M components/domain_reliability/context.cc View 4 chunks +13 lines, -2 lines 0 comments Download
M components/domain_reliability/context_manager.h View 2 chunks +3 lines, -0 lines 0 comments Download
M components/domain_reliability/context_manager.cc View 1 3 chunks +16 lines, -2 lines 0 comments Download
M components/domain_reliability/uploader.cc View 2 chunks +8 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 3 chunks +44 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (11 generated)
Julia Tuttle
PTAL, asvitkine.
4 years, 1 month ago (2016-10-31 23:20:17 UTC) #3
Julia Tuttle
https://codereview.chromium.org/2466093002/diff/1/components/domain_reliability/context_manager.cc File components/domain_reliability/context_manager.cc (left): https://codereview.chromium.org/2466093002/diff/1/components/domain_reliability/context_manager.cc#oldcode56 components/domain_reliability/context_manager.cc:56: DVLOG(1) << "Adding/replacing context for existing origin " << ...
4 years, 1 month ago (2016-10-31 23:32:06 UTC) #5
Alexei Svitkine (slow)
https://codereview.chromium.org/2466093002/diff/1/components/domain_reliability/context_manager.cc File components/domain_reliability/context_manager.cc (right): https://codereview.chromium.org/2466093002/diff/1/components/domain_reliability/context_manager.cc#newcode67 components/domain_reliability/context_manager.cc:67: true); Please refactor the code to avoid having two ...
4 years, 1 month ago (2016-11-01 14:49:46 UTC) #8
Julia Tuttle
PTAL, asvitkine. https://codereview.chromium.org/2466093002/diff/1/components/domain_reliability/context_manager.cc File components/domain_reliability/context_manager.cc (left): https://codereview.chromium.org/2466093002/diff/1/components/domain_reliability/context_manager.cc#oldcode56 components/domain_reliability/context_manager.cc:56: DVLOG(1) << "Adding/replacing context for existing origin ...
4 years, 1 month ago (2016-11-01 15:52:47 UTC) #10
Alexei Svitkine (slow)
lgtm
4 years, 1 month ago (2016-11-01 17:02:53 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2466093002/20001
4 years, 1 month ago (2016-11-01 18:06:23 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-01 18:12:40 UTC) #17
commit-bot: I haz the power
4 years, 1 month ago (2016-11-01 18:25:00 UTC) #19
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/dd99ca65f3c77b2de0d8d5a43c77d706152422c8
Cr-Commit-Position: refs/heads/master@{#429053}

Powered by Google App Engine
This is Rietveld 408576698