Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Unified Diff: components/domain_reliability/context.cc

Issue 2466093002: Domain Reliability: Add more upload-related histograms. (Closed)
Patch Set: A couple of tweaks. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/domain_reliability/context.h ('k') | components/domain_reliability/context_manager.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/domain_reliability/context.cc
diff --git a/components/domain_reliability/context.cc b/components/domain_reliability/context.cc
index bbbd78f8a4e740acc96ac4c9237c4bbca1bc4129..8cae5a7fbd2d021add2e5ae8552d260944a562f9 100644
--- a/components/domain_reliability/context.cc
+++ b/components/domain_reliability/context.cc
@@ -67,7 +67,7 @@ DomainReliabilityContext::~DomainReliabilityContext() {
ClearBeacons();
}
-void DomainReliabilityContext::OnBeacon(
+bool DomainReliabilityContext::OnBeacon(
std::unique_ptr<DomainReliabilityBeacon> beacon) {
bool success = (beacon->status == "ok");
double sample_rate = beacon->details.quic_port_migration_detected
@@ -80,7 +80,7 @@ void DomainReliabilityContext::OnBeacon(
// an older beacon. (This histogram is also logged below based on whether
// an older beacon was actually evicted.)
LogOnBeaconDidEvictHistogram(false);
- return;
+ return false;
}
beacon->sample_rate = sample_rate;
@@ -91,6 +91,8 @@ void DomainReliabilityContext::OnBeacon(
"DomainReliability.ReportedBeaconError_HasServerIP",
-beacon->chrome_error);
}
+ UMA_HISTOGRAM_COUNTS_100("DomainReliability.ReportedBeaconUploadDepth",
+ beacon->upload_depth);
// TODO(juliatuttle): Histogram HTTP response code?
// Allow beacons about reports, but don't schedule an upload for more than
@@ -103,6 +105,15 @@ void DomainReliabilityContext::OnBeacon(
RemoveOldestBeacon();
LogOnBeaconDidEvictHistogram(should_evict);
+
+ base::TimeTicks now = base::TimeTicks::Now();
+ if (last_queued_beacon_time_ != base::TimeTicks()) {
+ UMA_HISTOGRAM_LONG_TIMES("DomainReliability.BeaconInterval",
+ now - last_queued_beacon_time_);
+ }
+ last_queued_beacon_time_ = now;
+
+ return true;
}
void DomainReliabilityContext::ClearBeacons() {
« no previous file with comments | « components/domain_reliability/context.h ('k') | components/domain_reliability/context_manager.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698