Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2199)

Unified Diff: ash/common/devtools/ash_devtools_unittest.cc

Issue 2466073003: Push updates to inspector when windows are added, destroyed or reorganized (Closed)
Patch Set: use new devtools style Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ash/common/devtools/ash_devtools_unittest.cc
diff --git a/ash/common/devtools/ash_devtools_unittest.cc b/ash/common/devtools/ash_devtools_unittest.cc
index 65d77bec087f488460e1238fd6429b9a3ef12c1b..4bdcb034d756fc6d0cd081d6054616e722f78b93 100644
--- a/ash/common/devtools/ash_devtools_unittest.cc
+++ b/ash/common/devtools/ash_devtools_unittest.cc
@@ -146,6 +146,8 @@ TEST_F(AshDevToolsTest, GetDocumentWithWindowWidgetView) {
ASSERT_TRUE(widget_children->get(0)->getChildren(default_children));
Compare(child_view,
widget_children->get(0)->getChildren(default_children)->get(1));
+ // TODO(mhashmi): Remove this call and mock FrontendChannel
+ dom_agent()->disable();
sadrul 2016/11/04 15:39:17 When |widget| is destroyed, it should clean up the
Sarmad Hashmi 2016/11/04 16:03:50 The tear down of the |windows| on windows trybots
}
} // namespace ash

Powered by Google App Engine
This is Rietveld 408576698