ash/common/devtools/ash_devtools_unittest.cc - Issue 2466073003: Push updates to inspector when windows are added, destroyed or reorganized

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ash/common/devtools/ash_devtools_unittest.cc

Issue 2466073003: Push updates to inspector when windows are added, destroyed or reorganized (Closed)

Patch Set: use new devtools style Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « ash/common/devtools/ash_devtools_dom_agent.cc ('k') | components/ui_devtools/protocol.json » ('j') | components/ui_devtools/protocol.json » ('J')

OLD	NEW
1 // Copyright 2016 The Chromium Authors. All rights reserved.	1 // Copyright 2016 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "ash/common/devtools/ash_devtools_dom_agent.h"	5 #include "ash/common/devtools/ash_devtools_dom_agent.h"

6	6

7 #include "ash/common/test/ash_test.h"	7 #include "ash/common/test/ash_test.h"

8 #include "ash/common/wm_lookup.h"	8 #include "ash/common/wm_lookup.h"

9 #include "ash/common/wm_shell.h"	9 #include "ash/common/wm_shell.h"

10 #include "ash/common/wm_window.h"	10 #include "ash/common/wm_window.h"

(...skipping 128 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
139 Array<DOM::Node>* default_children = nullptr;	139 Array<DOM::Node>* default_children = nullptr;

140 ASSERT_TRUE(parent_node->getChildren(default_children));	140 ASSERT_TRUE(parent_node->getChildren(default_children));

141 Compare(child_window, parent_node->getChildren(default_children)->get(0));	141 Compare(child_window, parent_node->getChildren(default_children)->get(0));

142 Array<DOM::Node>* widget_children =	142 Array<DOM::Node>* widget_children =

143 widget_node->getChildren(default_children);	143 widget_node->getChildren(default_children);

144 ASSERT_TRUE(widget_children);	144 ASSERT_TRUE(widget_children);

145 Compare(widget->GetRootView(), widget_children->get(0));	145 Compare(widget->GetRootView(), widget_children->get(0));

146 ASSERT_TRUE(widget_children->get(0)->getChildren(default_children));	146 ASSERT_TRUE(widget_children->get(0)->getChildren(default_children));

147 Compare(child_view,	147 Compare(child_view,

148 widget_children->get(0)->getChildren(default_children)->get(1));	148 widget_children->get(0)->getChildren(default_children)->get(1));

	149 // TODO(mhashmi): Remove this call and mock FrontendChannel

	150 dom_agent()->disable();
	sadrul 2016/11/04 15:39:17 When \|widget\| is destroyed, it should clean up the When \|widget\| is destroyed, it should clean up the state from the appropriate callbacks, right? Why is it necessary to explicitly disable() here? Sarmad Hashmi 2016/11/04 16:03:50 The tear down of the \|windows\| on windows trybots Show quoted text On 2016/11/04 15:39:17, sadrul wrote: > When \|widget\| is destroyed, it should clean up the state from the appropriate > callbacks, right? Why is it necessary to explicitly disable() here? The tear down of the \|windows\| on windows trybots causes the test to crash in the generated files. Specifically, the backtrace crashes inside the Frontend methods, which are all generated. The crash is very similar to the one we saw before for the tests. I'll investigate more a bit later, but the tests work if we disable the agents since the Frontend methods are no longer called on tear down.
149 }	151 }

150	152

151 } // namespace ash	153 } // namespace ash

OLD	NEW