Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issue 2466013002: DevTools: [Workspace] show dirty asterisk in file tab title. (Closed)

Created:
4 years, 1 month ago by lushnikov
Modified:
4 years, 1 month ago
Reviewers:
dgozman
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2883
Project:
chromium
Visibility:
Public.

Description

DevTools: [Workspace] show dirty asterisk in file tab title. As we don't sync working copies between uiSourceCodes of persistent binding (for now), we should get the dirty state of the original uiSourceCode in the TabbedEditorContainer._titleForTab method. BUG=660238 R=dgozman Review-Url: https://codereview.chromium.org/2462493002 Cr-Commit-Position: refs/heads/master@{#428271} (cherry picked from commit bfa81c19d0c430c2df363f6f9685031cddb21785) Committed: https://chromium.googlesource.com/chromium/src/+/490721373725233a324418258002a4f702266d1c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M third_party/WebKit/Source/devtools/front_end/sources/TabbedEditorContainer.js View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
lushnikov
4 years, 1 month ago (2016-10-31 19:46:27 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
490721373725233a324418258002a4f702266d1c.

Powered by Google App Engine
This is Rietveld 408576698