Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issue 2462493002: DevTools: [Workspace] show dirty asterisk in file tab title. (Closed)

Created:
4 years, 1 month ago by lushnikov
Modified:
4 years, 1 month ago
Reviewers:
dgozman
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: [Workspace] show dirty asterisk in file tab title. As we don't sync working copies between uiSourceCodes of persistent binding (for now), we should get the dirty state of the original uiSourceCode in the TabbedEditorContainer._titleForTab method. BUG=660238 R=dgozman Committed: https://crrev.com/bfa81c19d0c430c2df363f6f9685031cddb21785 Cr-Commit-Position: refs/heads/master@{#428271}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M third_party/WebKit/Source/devtools/front_end/sources/TabbedEditorContainer.js View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
lushnikov
please, take a look I'd like to merge this to M-55 as well.
4 years, 1 month ago (2016-10-28 00:23:44 UTC) #1
dgozman
lgtm
4 years, 1 month ago (2016-10-28 00:52:03 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2462493002/1
4 years, 1 month ago (2016-10-28 03:21:20 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-28 03:30:54 UTC) #9
commit-bot: I haz the power
4 years, 1 month ago (2016-10-28 03:34:06 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bfa81c19d0c430c2df363f6f9685031cddb21785
Cr-Commit-Position: refs/heads/master@{#428271}

Powered by Google App Engine
This is Rietveld 408576698