Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Unified Diff: third_party/WebKit/Source/core/layout/svg/LayoutSVGGradientStop.h

Issue 2465983002: Rename "paint invalidation rect" etc. to "visual rect". (Closed)
Patch Set: - Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/svg/LayoutSVGGradientStop.h
diff --git a/third_party/WebKit/Source/core/layout/svg/LayoutSVGGradientStop.h b/third_party/WebKit/Source/core/layout/svg/LayoutSVGGradientStop.h
index 8960719f12ddaf52ab5fbff5da8fd5705ca8cd15..d398ee199c86680261d8073a51337cfae47c3c3b 100644
--- a/third_party/WebKit/Source/core/layout/svg/LayoutSVGGradientStop.h
+++ b/third_party/WebKit/Source/core/layout/svg/LayoutSVGGradientStop.h
@@ -42,15 +42,10 @@ class LayoutSVGGradientStop final : public LayoutObject {
void layout() override;
- // This overrides are needed to prevent ASSERTs on <svg><stop /></svg>
- // LayoutObject's default implementations ASSERT_NOT_REACHED()
- // https://bugs.webkit.org/show_bug.cgi?id=20400
chrishtr 2016/10/31 20:24:59 Why is this comment no longer applicable?
Xianzhu 2016/10/31 21:44:47 Updated.
- LayoutRect localOverflowRectForPaintInvalidation() const override {
- return LayoutRect();
- }
+ LayoutRect localVisualRect() const override { return LayoutRect(); }
FloatRect objectBoundingBox() const override { return FloatRect(); }
FloatRect strokeBoundingBox() const override { return FloatRect(); }
- FloatRect paintInvalidationRectInLocalSVGCoordinates() const override {
+ FloatRect visualRectInLocalSVGCoordinates() const override {
return FloatRect();
}
FloatRect localBoundingBoxRectForAccessibility() const final {

Powered by Google App Engine
This is Rietveld 408576698