Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Unified Diff: components/variations/DEPS

Issue 2465953002: Move Field Trial Utils from chrome/common/variations to components/variations/field_trial_util (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/variations/DEPS
diff --git a/components/variations/DEPS b/components/variations/DEPS
index 720e034fc7f9dd882705c12d087f54c090b7402b..11dfc78d95f34649daeaafed9df8ad159663df39 100644
--- a/components/variations/DEPS
+++ b/components/variations/DEPS
@@ -8,6 +8,7 @@ include_rules = [
"+components/variations",
"+crypto",
"-net",
+ "+net/base",
Alexei Svitkine (slow) 2016/10/31 17:22:38 Why do we need this? I guess for the URL escaping?
robliao 2016/10/31 17:26:25 Yes, this is specifically for URL escaping. We cou
Alexei Svitkine (slow) 2016/10/31 17:29:18 I was actually thinking the escaping from net/ cou
robliao 2016/10/31 17:35:12 components/metrics/field_trial_configs sgtm. Re:
robliao 2016/11/02 00:00:28 Done.
"+third_party/mt19937ar",
"+third_party/protobuf",
"+third_party/zlib/google",

Powered by Google App Engine
This is Rietveld 408576698