components/variations/DEPS - Issue 2465953002: Move Field Trial Utils from chrome/common/variations to components/variations/field_trial_util

Side by Side Diff: components/variations/DEPS

Issue 2465953002: Move Field Trial Utils from chrome/common/variations to components/variations/field_trial_util (Closed)

Patch Set: Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « components/variations/BUILD.gn ('k') | components/variations/fieldtrial_testing_config_schema.json » ('j') | components/variations/fieldtrial_util_unittest.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 # This component is shared with the Chrome OS build, so it's important to limit	1 # This component is shared with the Chrome OS build, so it's important to limit

2 # dependencies to a minimal set.	2 # dependencies to a minimal set.

3 include_rules = [	3 include_rules = [

4 "-components",	4 "-components",

5 "+components/compression",	5 "+components/compression",

6 "+components/crash/core/common",	6 "+components/crash/core/common",

7 "+components/prefs",	7 "+components/prefs",

8 "+components/variations",	8 "+components/variations",

9 "+crypto",	9 "+crypto",

10 "-net",	10 "-net",

	11 "+net/base",
	Alexei Svitkine (slow) 2016/10/31 17:22:38 Why do we need this? I guess for the URL escaping? Why do we need this? I guess for the URL escaping? I'd rather we don't depend on net/ since the metrics target is used by other things - such as the ChromeOS daemon and having extra dependencies would bloat that. Can the escaping be moving to its own component? robliao 2016/10/31 17:26:25 Yes, this is specifically for URL escaping. We cou Show quoted text On 2016/10/31 17:22:38, Alexei Svitkine (slow) wrote: > Why do we need this? I guess for the URL escaping? > > I'd rather we don't depend on net/ since the metrics target is used by other > things - such as the ChromeOS daemon and having extra dependencies would bloat > that. > > Can the escaping be moving to its own component? Yes, this is specifically for URL escaping. We could use a separate component for this, but I couldn't come up with an appropriate name and components/variations seemed like an appropriate home. Got a name? components/fieldtrial_utils or something? Alexei Svitkine (slow) 2016/10/31 17:29:18 I was actually thinking the escaping from net/ cou Show quoted text On 2016/10/31 17:26:25, robliao wrote: > On 2016/10/31 17:22:38, Alexei Svitkine (slow) wrote: > > Why do we need this? I guess for the URL escaping? > > > > I'd rather we don't depend on net/ since the metrics target is used by other > > things - such as the ChromeOS daemon and having extra dependencies would bloat > > that. > > > > Can the escaping be moving to its own component? > > Yes, this is specifically for URL escaping. We could use a separate component > for this, but I couldn't come up with an appropriate name and > components/variations seemed like an appropriate home. > > Got a name? components/fieldtrial_utils or something? I was actually thinking the escaping from net/ could be it's own component. e.g. components/url_escape Alternatively, this can be a sub-directory inside components/metrics - like we have service/ already which does depend on net. For example, components/metrics/field_trial_configs/ robliao 2016/10/31 17:35:12 components/metrics/field_trial_configs sgtm. Re: Show quoted text On 2016/10/31 17:29:18, Alexei Svitkine (slow) wrote: > On 2016/10/31 17:26:25, robliao wrote: > > On 2016/10/31 17:22:38, Alexei Svitkine (slow) wrote: > > > Why do we need this? I guess for the URL escaping? > > > > > > I'd rather we don't depend on net/ since the metrics target is used by other > > > things - such as the ChromeOS daemon and having extra dependencies would > bloat > > > that. > > > > > > Can the escaping be moving to its own component? > > > > Yes, this is specifically for URL escaping. We could use a separate component > > for this, but I couldn't come up with an appropriate name and > > components/variations seemed like an appropriate home. > > > > Got a name? components/fieldtrial_utils or something? > > I was actually thinking the escaping from net/ could be it's own component. e.g. > components/url_escape > > Alternatively, this can be a sub-directory inside components/metrics - like we > have service/ already which does depend on net. > > For example, components/metrics/field_trial_configs/ components/metrics/field_trial_configs sgtm. Re: Refactoring URL Escaping That will certainly be a more invasive change. (On the order of 40+ sites need to be updated). +net/base seems to be the way to specifically depend on things in net/base https://cs.chromium.org/search/?q=%5C%2Bnet/base+file:components&sq=package:c... I suspect all of those components just rely on dead code elimination to remove the unused parts of net from their components. What do you think? robliao 2016/11/02 00:00:28 Done. Show quoted text On 2016/10/31 17:35:12, robliao wrote: > On 2016/10/31 17:29:18, Alexei Svitkine (slow) wrote: > > On 2016/10/31 17:26:25, robliao wrote: > > > On 2016/10/31 17:22:38, Alexei Svitkine (slow) wrote: > > > > Why do we need this? I guess for the URL escaping? > > > > > > > > I'd rather we don't depend on net/ since the metrics target is used by > other > > > > things - such as the ChromeOS daemon and having extra dependencies would > > bloat > > > > that. > > > > > > > > Can the escaping be moving to its own component? > > > > > > Yes, this is specifically for URL escaping. We could use a separate > component > > > for this, but I couldn't come up with an appropriate name and > > > components/variations seemed like an appropriate home. > > > > > > Got a name? components/fieldtrial_utils or something? > > > > I was actually thinking the escaping from net/ could be it's own component. > e.g. > > components/url_escape > > > > Alternatively, this can be a sub-directory inside components/metrics - like we > > have service/ already which does depend on net. > > > > For example, components/metrics/field_trial_configs/ > > components/metrics/field_trial_configs sgtm. > > Re: Refactoring URL Escaping > That will certainly be a more invasive change. (On the order of 40+ sites need > to be updated). > > +net/base seems to be the way to specifically depend on things in net/base > https://cs.chromium.org/search/?q=%5C%2Bnet/base+file:components&sq=package:c... > > I suspect all of those components just rely on dead code elimination to remove > the unused parts of net from their components. What do you think? Done.
11 "+third_party/mt19937ar",	12 "+third_party/mt19937ar",

12 "+third_party/protobuf",	13 "+third_party/protobuf",

13 "+third_party/zlib/google",	14 "+third_party/zlib/google",

14 ]	15 ]

OLD	NEW