[turbofan] Move OSR BailoutId translation into graph builder.

[turbofan] Move OSR BailoutId translation into graph builder.

This moves the location of the bytecode-offset translation that turns
offsets of back jumps into offsets of loop headers. This translation is
now done by the {BytecodeGraphBuilder} after loop analysis has been
performed. It safes one redudant iteration over the bytecode array. Note
that this changes the semantics of the BailoutId used as an {osr_ast_id}
throughout the compiler pipeline for OSR from Ignition.

R=jarin@chromium.org

Committed: https://crrev.com/8893d4ff58080fdef9d232ad4b2f95af19bfa6e6
Cr-Commit-Position: refs/heads/master@{#41431}

[Michael Starzinger, 2016-10-31 14:47:00]

The CQ bit was checked by mstarzinger@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-31 14:47:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Michael Starzinger, 2016-10-31 14:48:57]

Description was changed from

==========
[turbofan] Move OSR BailoutId translation into graph builder.

This move the translation of the bytecode-offset translation that turns
offsets of backwards jumpt to offsets of loop headers. This translation
is now done by the {BytecodeGraphBuilder} after loop analysis has been
performed. It safes one redudant iteration over the bytecode array. Note
that this changes the semantics of the BailoutId used as an {osr_ast_id}
throughout the compiler pipeline for OSR from Ignition.

R=jarin@chromium.org
==========

to

==========
[turbofan] Move OSR BailoutId translation into graph builder.

This moves the location of the bytecode-offset translation that turns
offsets of back jumps intoto offsets of loop headers. This translation
is now done by the {BytecodeGraphBuilder} after loop analysis has been
performed. It safes one redudant iteration over the bytecode array. Note
that this changes the semantics of the BailoutId used as an {osr_ast_id}
throughout the compiler pipeline for OSR from Ignition.

R=jarin@chromium.org
==========

[Michael Starzinger, 2016-10-31 14:49:57]

mstarzinger@chromium.org changed reviewers:
+ rmcilroy@chromium.org

[Michael Starzinger, 2016-10-31 14:49:57]

Jaro: PTAL.
Ross: FYI.

[commit-bot: I haz the power, 2016-10-31 14:58:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-31 14:58:34]

Dry run: Try jobs failed on following builders:
  v8_linux64_asan_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel_ng/buil...)
  v8_linux64_asan_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel_ng_trig...)

[Jarin, 2016-10-31 14:59:39]

lgtm

https://codereview.chromium.org/2465913002/diff/1/src/compiler/bytecode-graph...
File src/compiler/bytecode-graph-builder.h (right):

https://codereview.chromium.org/2465913002/diff/1/src/compiler/bytecode-graph...
src/compiler/bytecode-graph-builder.h:209: // [offset], if any.
Nit: above we seem to be using "{offset}" to refer to code, perhaps we should do
the same here?

[rmcilroy, 2016-11-01 13:06:03]

"intoto" typo in description. 

LGTM once the bots are happy.

[Michael Starzinger, 2016-11-02 09:36:34]

Description was changed from

==========
[turbofan] Move OSR BailoutId translation into graph builder.

This moves the location of the bytecode-offset translation that turns
offsets of back jumps intoto offsets of loop headers. This translation
is now done by the {BytecodeGraphBuilder} after loop analysis has been
performed. It safes one redudant iteration over the bytecode array. Note
that this changes the semantics of the BailoutId used as an {osr_ast_id}
throughout the compiler pipeline for OSR from Ignition.

R=jarin@chromium.org
==========

to

==========
[turbofan] Move OSR BailoutId translation into graph builder.

This moves the location of the bytecode-offset translation that turns
offsets of back jumps into offsets of loop headers. This translation is
now done by the {BytecodeGraphBuilder} after loop analysis has been
performed. It safes one redudant iteration over the bytecode array. Note
that this changes the semantics of the BailoutId used as an {osr_ast_id}
throughout the compiler pipeline for OSR from Ignition.

R=jarin@chromium.org
==========

[Michael Starzinger, 2016-12-01 11:58:11]

The CQ bit was checked by mstarzinger@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-01 11:58:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-01 12:23:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-01 12:23:23]

Dry run: This issue passed the CQ dry run.

[Michael Starzinger, 2016-12-01 12:49:56]

mstarzinger@chromium.org changed reviewers:
+ leszeks@chromium.org

[Michael Starzinger, 2016-12-01 12:49:57]

Jaro & Leszek: PTAL specifically at the bytecode analysis. I had to add a change
in order to get wide-operand jumps working correctly.

https://codereview.chromium.org/2465913002/diff/20001/src/compiler/bytecode-a...
File src/compiler/bytecode-analysis.cc (right):

https://codereview.chromium.org/2465913002/diff/20001/src/compiler/bytecode-a...
src/compiler/bytecode-analysis.cc:166: int loop_end = current_offset +
iterator.current_bytecode_size() - 1;
Jaro & Leszek: Please confirm that you are fine with this change to the
semantics of keys stored within the {end_to_header_} table.

[Jarin, 2016-12-01 13:49:29]

https://codereview.chromium.org/2465913002/diff/20001/src/compiler/bytecode-a...
File src/compiler/bytecode-analysis.cc (right):

https://codereview.chromium.org/2465913002/diff/20001/src/compiler/bytecode-a...
src/compiler/bytecode-analysis.cc:166: int loop_end = current_offset +
iterator.current_bytecode_size() - 1;
On 2016/12/01 12:49:56, Michael Starzinger wrote:
> Jaro & Leszek: Please confirm that you are fine with this change to the
> semantics of keys stored within the {end_to_header_} table.

lgtm.

[Leszek Swirski, 2016-12-01 13:50:00]

lgtm

https://codereview.chromium.org/2465913002/diff/20001/src/compiler/bytecode-a...
File src/compiler/bytecode-analysis.cc (right):

https://codereview.chromium.org/2465913002/diff/20001/src/compiler/bytecode-a...
src/compiler/bytecode-analysis.cc:166: int loop_end = current_offset +
iterator.current_bytecode_size() - 1;
On 2016/12/01 12:49:56, Michael Starzinger wrote:
> Jaro & Leszek: Please confirm that you are fine with this change to the
> semantics of keys stored within the {end_to_header_} table.

Fine with me. You can remove the -1 if you change GetLoopOffsetFor to look for
upper_bound (exclusive end search) instead of lower_bound (inclusive end
search).

[Michael Starzinger, 2016-12-01 13:57:27]

The CQ bit was checked by mstarzinger@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-01 13:57:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Michael Starzinger, 2016-12-01 13:57:44]

Thanks! Addressed comments. Landing.

https://codereview.chromium.org/2465913002/diff/20001/src/compiler/bytecode-a...
File src/compiler/bytecode-analysis.cc (right):

https://codereview.chromium.org/2465913002/diff/20001/src/compiler/bytecode-a...
src/compiler/bytecode-analysis.cc:166: int loop_end = current_offset +
iterator.current_bytecode_size() - 1;
On 2016/12/01 13:50:00, Leszek Swirski wrote:
> On 2016/12/01 12:49:56, Michael Starzinger wrote:
> > Jaro & Leszek: Please confirm that you are fine with this change to the
> > semantics of keys stored within the {end_to_header_} table.
> 
> Fine with me. You can remove the -1 if you change GetLoopOffsetFor to look for
> upper_bound (exclusive end search) instead of lower_bound (inclusive end
> search).

Done.

[commit-bot: I haz the power, 2016-12-01 14:21:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-01 14:21:55]

Dry run: This issue passed the CQ dry run.

[Michael Starzinger, 2016-12-01 14:22:04]

The CQ bit was checked by mstarzinger@chromium.org

[Michael Starzinger, 2016-12-01 14:22:05]

The patchset sent to the CQ was uploaded after l-g-t-m from
rmcilroy@chromium.org, jarin@chromium.org, leszeks@chromium.org
Link to the patchset: https://codereview.chromium.org/2465913002/#ps40001
(title: "Addressed comments.")

[commit-bot: I haz the power, 2016-12-01 14:22:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-01 14:24:11]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1480602124667290,
"parent_rev": "19be4ece8eea19573d78496b7ddc34d88211bc7c", "commit_rev":
"2d7047c0c6c28f5a02c149c73a62fed77f469c98"}

[commit-bot: I haz the power, 2016-12-01 14:24:17]

Description was changed from

==========
[turbofan] Move OSR BailoutId translation into graph builder.

This moves the location of the bytecode-offset translation that turns
offsets of back jumps into offsets of loop headers. This translation is
now done by the {BytecodeGraphBuilder} after loop analysis has been
performed. It safes one redudant iteration over the bytecode array. Note
that this changes the semantics of the BailoutId used as an {osr_ast_id}
throughout the compiler pipeline for OSR from Ignition.

R=jarin@chromium.org
==========

to

==========
[turbofan] Move OSR BailoutId translation into graph builder.

This moves the location of the bytecode-offset translation that turns
offsets of back jumps into offsets of loop headers. This translation is
now done by the {BytecodeGraphBuilder} after loop analysis has been
performed. It safes one redudant iteration over the bytecode array. Note
that this changes the semantics of the BailoutId used as an {osr_ast_id}
throughout the compiler pipeline for OSR from Ignition.

R=jarin@chromium.org
==========

[commit-bot: I haz the power, 2016-12-01 14:24:19]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-12-01 14:24:33]

Description was changed from

==========
[turbofan] Move OSR BailoutId translation into graph builder.

This moves the location of the bytecode-offset translation that turns
offsets of back jumps into offsets of loop headers. This translation is
now done by the {BytecodeGraphBuilder} after loop analysis has been
performed. It safes one redudant iteration over the bytecode array. Note
that this changes the semantics of the BailoutId used as an {osr_ast_id}
throughout the compiler pipeline for OSR from Ignition.

R=jarin@chromium.org
==========

to

==========
[turbofan] Move OSR BailoutId translation into graph builder.

This moves the location of the bytecode-offset translation that turns
offsets of back jumps into offsets of loop headers. This translation is
now done by the {BytecodeGraphBuilder} after loop analysis has been
performed. It safes one redudant iteration over the bytecode array. Note
that this changes the semantics of the BailoutId used as an {osr_ast_id}
throughout the compiler pipeline for OSR from Ignition.

R=jarin@chromium.org

Committed: https://crrev.com/8893d4ff58080fdef9d232ad4b2f95af19bfa6e6
Cr-Commit-Position: refs/heads/master@{#41431}
==========

[commit-bot: I haz the power, 2016-12-01 14:24:34]

Patchset 3 (id:??) landed as
https://crrev.com/8893d4ff58080fdef9d232ad4b2f95af19bfa6e6
Cr-Commit-Position: refs/heads/master@{#41431}