[turbofan] Move OSR BailoutId translation into graph builder.

src/compiler/bytecode-analysis.cc

 // Copyright 2016 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/compiler/bytecode-analysis.h"
 
 #include "src/interpreter/bytecode-array-iterator.h"
 #include "src/interpreter/bytecode-array-reverse-iterator.h"
 #include "src/objects-inl.h"
 
@@ skipping 143 matching lines @@
   // The last JumpLoop that we haven't done a guaranteed valid liveness pass
   // over. See the below wall of text for a more thorough explanation.
   int last_invalid_jumploop_offset = -1;
 
   BytecodeArrayReverseIterator iterator(bytecode_array(), zone());
   for (; !iterator.done(); iterator.Advance()) {
     Bytecode bytecode = iterator.current_bytecode();
     int current_offset = iterator.current_offset();
 
     if (bytecode == Bytecode::kJumpLoop) {
-      PushLoop(iterator.GetJumpTargetOffset(), current_offset);
+      // Every byte up to and including the last byte within the backwards jump
+      // instruction is considered part of the loop, set loop end accordingly.
+      int loop_end = current_offset + iterator.current_bytecode_size() - 1;

[Michael Starzinger, 2016/12/01 12:49:56]

Jaro & Leszek: Please confirm that you are fine with this change to the
semantics of keys stored within the {end_to_header_} table.

[Jarin, 2016/12/01 13:49:29]

lgtm.

[Leszek Swirski, 2016/12/01 13:50:00]

Fine with me. You can remove the -1 if you change GetLoopOffsetFor to look for
upper_bound (exclusive end search) instead of lower_bound (inclusive end
search).

[Michael Starzinger, 2016/12/01 13:57:44]

Done.

+      PushLoop(iterator.GetJumpTargetOffset(), loop_end);
 
       // Save the last offset so that we can do another pass later.
       if (last_invalid_jumploop_offset == -1) {
         last_invalid_jumploop_offset = current_offset;
       }
     } else if (current_offset == loop_stack_.top()) {
       loop_stack_.pop();
     }
 
     if (do_liveness_analysis_) {
@@ skipping 317 matching lines @@
     }
   }
 
   return invalid_offset == -1;
 }
 #endif
 
 }  // namespace compiler
 }  // namespace internal
 }  // namespace v8