Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issue 2465823002: bluetooth: Make BluetoothRemoteGATTCharacteristic Persistent (Closed)

Created:
4 years, 1 month ago by ortuno
Modified:
4 years, 1 month ago
Reviewers:
scheib
CC:
blink-reviews, chromium-reviews, haraken, ortuno+watch_chromium.org, scheib+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

bluetooth: Make BluetoothRemoteGATTCharacteristic Persistent Since it was WeakPersistent the characteristic was getting garbage collected which lead to a crash when the response arrived. Also adds tests for all the relevant functions. BUG=659182 Committed: https://crrev.com/35d4f33d891b86e982d9f010285fc71937de3bf2 Cr-Commit-Position: refs/heads/master@{#429509}

Patch Set 1 #

Patch Set 2 : Add tests #

Patch Set 3 : Clean tests #

Patch Set 4 : Moar clean up #

Patch Set 5 : Moar clean up #

Patch Set 6 : git cl try #

Unified diffs Side-by-side diffs Delta from patch set Stats (+760 lines, -2 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/bluetooth/connect/garbage-collection-ran-during-error.html View 1 2 3 1 chunk +17 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/bluetooth/connect/garbage-collection-ran-during-success.html View 1 2 3 1 chunk +17 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/bluetooth/getCharacteristic/gen-characteristic-garbage-collection-ran-during-error.html View 1 2 1 chunk +30 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/bluetooth/getCharacteristic/gen-characteristic-garbage-collection-ran-during-success.html View 1 2 1 chunk +30 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/bluetooth/getCharacteristics/gen-characteristic-garbage-collection-ran-during-error.html View 1 2 1 chunk +30 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/bluetooth/getCharacteristics/gen-characteristic-garbage-collection-ran-during-error-with-uuid.html View 1 2 1 chunk +30 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/bluetooth/getCharacteristics/gen-characteristic-garbage-collection-ran-during-success.html View 1 2 1 chunk +30 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/bluetooth/getCharacteristics/gen-characteristic-garbage-collection-ran-during-success-with-uuid.html View 1 2 1 chunk +30 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/bluetooth/getPrimaryService/gen-service-garbage-collection-ran-during-error.html View 1 2 1 chunk +29 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/bluetooth/getPrimaryService/gen-service-garbage-collection-ran-during-success.html View 1 2 1 chunk +27 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/bluetooth/getPrimaryServices/gen-service-garbage-collection-ran-during-error.html View 1 2 1 chunk +29 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/bluetooth/getPrimaryServices/gen-service-garbage-collection-ran-during-error-with-uuid.html View 1 2 1 chunk +29 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/bluetooth/getPrimaryServices/gen-service-garbage-collection-ran-during-success.html View 1 2 1 chunk +27 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/bluetooth/getPrimaryServices/gen-service-garbage-collection-ran-during-success-with-uuid.html View 1 2 1 chunk +27 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/bluetooth/readValue/gen-gatt-op-garbage-collection-ran-during-error.html View 1 2 1 chunk +32 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/bluetooth/readValue/gen-gatt-op-garbage-collection-ran-during-success.html View 1 2 3 1 chunk +32 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/bluetooth/script-tests/characteristic-garbage-collection-ran-during-error.js View 1 2 1 chunk +25 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/bluetooth/script-tests/characteristic-garbage-collection-ran-during-success.js View 1 2 1 chunk +25 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/bluetooth/script-tests/gatt-op-garbage-collection-ran-during-error.js View 1 2 1 chunk +27 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/bluetooth/script-tests/gatt-op-garbage-collection-ran-during-success.js View 1 2 3 1 chunk +28 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/bluetooth/script-tests/service-garbage-collection-ran-during-error.js View 1 2 1 chunk +24 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/bluetooth/script-tests/service-garbage-collection-ran-during-success.js View 1 2 1 chunk +22 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/bluetooth/startNotifications/gen-gatt-op-garbage-collection-ran-during-error.html View 1 2 1 chunk +32 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/bluetooth/startNotifications/gen-gatt-op-garbage-collection-ran-during-success.html View 1 2 3 1 chunk +32 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/bluetooth/stopNotifications/gen-gatt-op-garbage-collection-ran-during-success.html View 1 2 3 1 chunk +32 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/bluetooth/writeValue/gen-gatt-op-garbage-collection-ran-during-error.html View 1 2 1 chunk +32 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/bluetooth/writeValue/gen-gatt-op-garbage-collection-ran-during-success.html View 1 2 3 1 chunk +32 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTCharacteristic.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 18 (12 generated)
ortuno
4 years, 1 month ago (2016-11-02 05:13:41 UTC) #3
scheib
LGTM
4 years, 1 month ago (2016-11-03 01:20:02 UTC) #12
ortuno
Thanks!
4 years, 1 month ago (2016-11-03 01:41:38 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2465823002/100001
4 years, 1 month ago (2016-11-03 01:41:53 UTC) #15
commit-bot: I haz the power
Committed patchset #6 (id:100001)
4 years, 1 month ago (2016-11-03 01:58:54 UTC) #16
commit-bot: I haz the power
4 years, 1 month ago (2016-11-03 02:03:01 UTC) #18
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/35d4f33d891b86e982d9f010285fc71937de3bf2
Cr-Commit-Position: refs/heads/master@{#429509}

Powered by Google App Engine
This is Rietveld 408576698