third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTCharacteristic.cpp - Issue 2465823002: bluetooth: Make BluetoothRemoteGATTCharacteristic Persistent

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTCharacteristic.cpp

Issue 2465823002: bluetooth: Make BluetoothRemoteGATTCharacteristic Persistent (Closed)

Patch Set: git cl try Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/bluetooth/writeValue/gen-gatt-op-garbage-collection-ran-during-success.html ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTCharacteristic.cpp

diff --git a/third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTCharacteristic.cpp b/third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTCharacteristic.cpp

index df461634afbf54149e8873b58ca8a530ff6c5fc5..53c3f395aa3b4b0021ccd28df17de8b7c31a179e 100644

--- a/third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTCharacteristic.cpp

+++ b/third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTCharacteristic.cpp

@@ -169,7 +169,7 @@ class ReadValueCallback : public WebBluetoothReadValueCallbacks {

}

private:

- WeakPersistent<BluetoothRemoteGATTCharacteristic> m_characteristic;

+ Persistent<BluetoothRemoteGATTCharacteristic> m_characteristic;

Persistent<ScriptPromiseResolver> m_resolver;

};

@@ -240,7 +240,7 @@ class WriteValueCallback : public WebBluetoothWriteValueCallbacks {

}

private:

- WeakPersistent<BluetoothRemoteGATTCharacteristic> m_characteristic;

+ Persistent<BluetoothRemoteGATTCharacteristic> m_characteristic;

Persistent<ScriptPromiseResolver> m_resolver;

};