Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Issue 2465743002: Trybot test for losing style (Closed)

Created:
4 years, 1 month ago by yabinh
Modified:
3 years, 10 months ago
Reviewers:
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Trybot test for losing style

Patch Set 1 #

Patch Set 2 : "don't change. see what happnes" #

Patch Set 3 : events #

Patch Set 4 : format #

Patch Set 5 : try again #

Patch Set 6 : 19:08 #

Patch Set 7 : try again #

Patch Set 8 : format #

Total comments: 1

Patch Set 9 : remove dcheck #

Patch Set 10 : Fix 2 tests #

Patch Set 11 : add test. change selection #

Patch Set 12 : format #

Patch Set 13 : For textInput event #

Patch Set 14 : "correct. see the diff" #

Patch Set 15 : git cl try #

Patch Set 16 : fix crash #

Total comments: 1

Patch Set 17 : format #

Patch Set 18 : 12.1 11:46 #

Patch Set 19 : 12.1 11:55 #

Patch Set 20 : compile error. 13:37 #

Patch Set 21 : 15:26 #

Patch Set 22 : update 16:05 #

Patch Set 23 : no workaround 16:45 #

Patch Set 24 : fix layoutTest. 18:38 #

Patch Set 25 : with workaround 18:40 #

Patch Set 26 : workaround. call insert #

Patch Set 27 : fix crash in local test 19:40 #

Total comments: 1

Patch Set 28 : avoid crash 12.2 10:48 #

Patch Set 29 : fix a max len test 12.1 11:08 #

Patch Set 30 : fix crash of webview test 11:13 #

Patch Set 31 : when old is empty or new is empty, use old insert. 11:53 #

Total comments: 1

Patch Set 32 : 13:29 #

Patch Set 33 : 13:57 #

Patch Set 34 : remove updateStyle 14:08 #

Patch Set 35 : split Ime test 14:33 #

Patch Set 36 : donnot clear 14:38 #

Total comments: 1

Patch Set 37 : donnot updateStyle 2. 14:41 #

Patch Set 38 : donnot updateStyle 3. 14:42 #

Patch Set 39 : donnot updateStyle 4. 14:43 #

Patch Set 40 : donnot updateStyle. 14:46 #

Patch Set 41 : keep clear(). move workaround to upper level. remove some logs. 15:15 #

Patch Set 42 : remove logs. change imetest. 16:10 #

Patch Set 43 : move clear(). 16:29 #

Patch Set 44 : a little change. 16:43 #

Patch Set 45 : Rebase #

Patch Set 46 : merge. not return text. 12.05 10:31 #

Patch Set 47 : canEditRich 10:42 #

Patch Set 48 : move 1 change selection to the end. 12:03 #

Patch Set 49 : Refactor. 15:43 #

Patch Set 50 : protect. 16:14 #

Patch Set 51 : if canceled, return #

Patch Set 52 : add an event type. 18:37 #

Patch Set 53 : change selection at upper level 18:05 #

Patch Set 54 : 18:32 #

Patch Set 55 : 19:49 #

Total comments: 2

Patch Set 56 : no selection crash 21:37 #

Patch Set 57 : try to avoid carsh 10:59 #

Patch Set 58 : keep dcheck 11:08 #

Patch Set 59 : move another place to avoid crash 12:34 #

Patch Set 60 : move another place to avoid crash 13:46 #

Patch Set 61 : not change start selection1 13:52 #

Patch Set 62 : not change start selection2 13:55 #

Patch Set 63 : remove getselectionoffset 14:52 #

Patch Set 64 : 16:11 #

Patch Set 65 : remove static 16:27 #

Patch Set 66 : 12.9 14:25 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+521 lines, -245 lines) Patch
M content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 1 chunk +22 lines, -18 lines 0 comments Download
M third_party/WebKit/Source/core/editing/BUILD.gn View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/editing/Editor.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/editing/InputMethodController.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 2 chunks +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/editing/InputMethodController.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 53 54 55 56 57 58 59 60 61 62 63 64 65 10 chunks +23 lines, -166 lines 0 comments Download
M third_party/WebKit/Source/core/editing/InputMethodControllerTest.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 5 chunks +69 lines, -6 lines 0 comments Download
A third_party/WebKit/Source/core/editing/commands/InsertIncrementalTextCommand.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 1 chunk +30 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/editing/commands/InsertIncrementalTextCommand.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 1 chunk +178 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/InsertTextCommand.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/TypingCommand.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 4 chunks +12 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/TypingCommand.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 8 chunks +171 lines, -45 lines 0 comments Download
M third_party/WebKit/Source/core/editing/iterators/CharacterIterator.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/events/TextEvent.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/events/TextEventInputType.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/web/tests/WebViewTest.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 180 (179 generated)
yabinh
3 years, 10 months ago (2017-02-08 09:59:59 UTC) #180
Message was sent while issue was closed.
https://codereview.chromium.org/2465743002/diff/140001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/editing/commands/TypingCommand.cpp (right):

https://codereview.chromium.org/2465743002/diff/140001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/editing/commands/TypingCommand.cpp:434: const
size_t selectionEnd = selectionOffsets.end();
setComposition
// selection may change when calling ic.setC() directly
commitText

https://codereview.chromium.org/2465743002/diff/300001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/editing/commands/TypingCommand.cpp (right):

https://codereview.chromium.org/2465743002/diff/300001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/editing/commands/TypingCommand.cpp:448: //
TODO(xiaochengh): The use of
move to 1 line...

https://codereview.chromium.org/2465743002/diff/520001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/editing/commands/TypingCommand.cpp (right):

https://codereview.chromium.org/2465743002/diff/520001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/editing/commands/TypingCommand.cpp:246: 
here?

https://codereview.chromium.org/2465743002/diff/600001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/editing/commands/TypingCommand.cpp (right):

https://codereview.chromium.org/2465743002/diff/600001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/editing/commands/TypingCommand.cpp:238: if
(compositionType !=
// fast/forms/text/input-maxlength-ime-completed.html

https://codereview.chromium.org/2465743002/diff/700001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/editing/InputMethodController.cpp (right):

https://codereview.chromium.org/2465743002/diff/700001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/editing/InputMethodController.cpp:307: //
clear();  // do we need clear???
It turns out that we should clear.

https://codereview.chromium.org/2465743002/diff/1090001/third_party/WebKit/So...
File third_party/WebKit/Source/core/editing/commands/TypingCommand.cpp (right):

https://codereview.chromium.org/2465743002/diff/1090001/third_party/WebKit/So...
third_party/WebKit/Source/core/editing/commands/TypingCommand.cpp:228:
DCHECK(element);
failed.
insert-text-into-empty-frameset-crash.html

https://codereview.chromium.org/2465743002/diff/1090001/third_party/WebKit/So...
third_party/WebKit/Source/core/editing/commands/TypingCommand.cpp:232:
DCHECK(startRange.isNotNull());
failed.
keydown-without-selection-crash.html
focus-on-control-with-zero-size.html

Powered by Google App Engine
This is Rietveld 408576698