third_party/WebKit/Source/core/editing/iterators/CharacterIterator.cpp - Issue 2465743002: Trybot test for losing style

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/iterators/CharacterIterator.cpp

Issue 2465743002: Trybot test for losing style (Closed)

Patch Set: 12.9 14:25 Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/editing/commands/TypingCommand.cpp ('k') | third_party/WebKit/Source/core/events/TextEvent.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/iterators/CharacterIterator.cpp

diff --git a/third_party/WebKit/Source/core/editing/iterators/CharacterIterator.cpp b/third_party/WebKit/Source/core/editing/iterators/CharacterIterator.cpp

index 73404bec56e04cc7316619bf03240e7864d90514..19b4b31007f8b577f060b5ca335f26f4eab7ebab 100644

--- a/third_party/WebKit/Source/core/editing/iterators/CharacterIterator.cpp

+++ b/third_party/WebKit/Source/core/editing/iterators/CharacterIterator.cpp

@@ -189,6 +189,8 @@ CharacterIteratorAlgorithm<Strategy>::calculateCharacterSubrange(int offset,

advance(offset);

const PositionTemplate<Strategy> startPos = startPosition();

+ if (!length)

+ return EphemeralRangeTemplate<Strategy>(startPos, startPos);

if (length > 1)

advance(length - 1);

return EphemeralRangeTemplate<Strategy>(startPos, endPosition());