Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3528)

Unified Diff: chrome/browser/ui/views/download/download_item_view.cc

Issue 2465723004: Make download warning icon and text more consistent (Closed)
Patch Set: rebase Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/download/download_item_view.cc
diff --git a/chrome/browser/ui/views/download/download_item_view.cc b/chrome/browser/ui/views/download/download_item_view.cc
index f22135871709b79f713d6468c86e07f52fbd6b5f..6a49d324bf5c22ebbdbf72f4195b04bc1290b966 100644
--- a/chrome/browser/ui/views/download/download_item_view.cc
+++ b/chrome/browser/ui/views/download/download_item_view.cc
@@ -972,8 +972,10 @@ gfx::ImageSkia DownloadItemView::GetWarningIcon() {
case content::DOWNLOAD_DANGER_TYPE_UNCOMMON_CONTENT:
case content::DOWNLOAD_DANGER_TYPE_DANGEROUS_HOST:
case content::DOWNLOAD_DANGER_TYPE_POTENTIALLY_UNWANTED:
- return gfx::CreateVectorIcon(gfx::VectorIconId::REMOVE_CIRCLE,
- kWarningIconSize, gfx::kGoogleRed700);
Dan Beam 2016/11/01 18:49:50 can we just use google red everywhere? it's prett
Jialiu Lin 2016/11/01 21:19:01 Agree. I cannot tell the difference between these
+ case content::DOWNLOAD_DANGER_TYPE_DANGEROUS_FILE:
+ return gfx::CreateVectorIcon(gfx::VectorIconId::WARNING,
+ kWarningIconSize,
+ gfx::kSafeBrowsingWarningRed);
case content::DOWNLOAD_DANGER_TYPE_NOT_DANGEROUS:
case content::DOWNLOAD_DANGER_TYPE_MAYBE_DANGEROUS_CONTENT:
@@ -981,10 +983,6 @@ gfx::ImageSkia DownloadItemView::GetWarningIcon() {
case content::DOWNLOAD_DANGER_TYPE_MAX:
NOTREACHED();
break;
-
- case content::DOWNLOAD_DANGER_TYPE_DANGEROUS_FILE:
- return gfx::CreateVectorIcon(gfx::VectorIconId::WARNING, kWarningIconSize,
- gfx::kGoogleYellow700);
}
return gfx::ImageSkia();
}

Powered by Google App Engine
This is Rietveld 408576698