Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(726)

Unified Diff: recipe_modules/properties/test_api.py

Issue 2465703003: Fix issue overriding bug properties.test_api.tryserver for Gerrit. (Closed)
Patch Set: space Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « recipe_modules/properties/example.expected/buildbot_tryserver_gerrit_override_both.json ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: recipe_modules/properties/test_api.py
diff --git a/recipe_modules/properties/test_api.py b/recipe_modules/properties/test_api.py
index 069efd14d1860bb63f679216abd997f666754454..90780d171dcbc201c4b1531553e6362d3f844a57 100644
--- a/recipe_modules/properties/test_api.py
+++ b/recipe_modules/properties/test_api.py
@@ -85,9 +85,9 @@ class PropertiesTestApi(recipe_test_api.RecipeTestApi):
assert project
assert git_url
assert gerrit_url
- # Pop old style values from kwargs.
- patch_issue = int(kwargs.pop('issue', 456789))
- patch_set = int(kwargs.pop('patchset', 12))
+ # Support old and new style patch{set,issue} specification.
+ patch_issue = int(kwargs.pop('issue', kwargs.pop('patch_issue', 456789)))
+ patch_set = int(kwargs.pop('patchset', kwargs.pop('patch_set', 12)))
# Note that new Gerrit patch properties all start with 'patch_' prefix.
ret = self.generic(
patch_storage='gerrit',
« no previous file with comments | « recipe_modules/properties/example.expected/buildbot_tryserver_gerrit_override_both.json ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698