Add script files of the separated Gallery.app.

This CL adds the script files of the separated Gallery.app.
Gallery.app refers a few Files.app script files, so the CL also changes so that the files can be imported from the Gallery.app

BUG=358698
TEST=manually

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266531

[hirono, 2014-04-22 03:41:49]

PTAL the CL? Thank you!

[hirono, 2014-04-22 07:29:43]

On 2014/04/22 03:41:49, hirono wrote:
> PTAL the CL? Thank you!

I'll update paths after committing crrev.com/246983002.

[yoshiki, 2014-04-23 07:08:39]

https://codereview.chromium.org/246543002/diff/60001/chrome/browser/resources...
File
chrome/browser/resources/file_manager/foreground/js/metadata/metadata_cache.js
(right):

https://codereview.chromium.org/246543002/diff/60001/chrome/browser/resources...
chrome/browser/resources/file_manager/foreground/js/metadata/metadata_cache.js:879:
dispatcher.start();
I think, it's better to put start() after adding message handler.

https://codereview.chromium.org/246543002/diff/60001/chrome/browser/resources...
chrome/browser/resources/file_manager/foreground/js/metadata/metadata_cache.js:895:
* @type {string}
@const

https://codereview.chromium.org/246543002/diff/60001/chrome/browser/resources...
File chrome/browser/resources/file_manager/manifest.json (right):

https://codereview.chromium.org/246543002/diff/60001/chrome/browser/resources...
chrome/browser/resources/file_manager/manifest.json:198:
"foreground/js/metadata/*.js"
Could you move the follwoing file/directory into common/?
- foreground/js/metadata
- background/js/test_util.js

I think 'common' is better place.

https://codereview.chromium.org/246543002/diff/60001/chrome/browser/resources...
File chrome/browser/resources/gallery/gallery.html (right):

https://codereview.chromium.org/246543002/diff/60001/chrome/browser/resources...
chrome/browser/resources/gallery/gallery.html:8: <meta
http-equiv="Content-Security-Policy" content="script-src chrome-extension://;">
Could you specify this policy in manifest.json, instead of here?

chrome-extension:// is not safe. Please specify the extension ID in addition.

https://codereview.chromium.org/246543002/diff/60001/chrome/browser/resources...
File chrome/browser/resources/gallery/js/gallery.js (right):

https://codereview.chromium.org/246543002/diff/60001/chrome/browser/resources...
chrome/browser/resources/gallery/js/gallery.js:23: * @param {VolumeManager}
volumeManager The VolumeManager instance of the
non-nullable

https://codereview.chromium.org/246543002/diff/60001/chrome/browser/resources...
chrome/browser/resources/gallery/js/gallery.js:24: *      system.
4 space indent.

https://codereview.chromium.org/246543002/diff/60001/chrome/browser/resources...
chrome/browser/resources/gallery/js/gallery.js:30: appWindow:
chrome.app.window.current(),
4 space indent.

https://codereview.chromium.org/246543002/diff/60001/chrome/browser/resources...
chrome/browser/resources/gallery/js/gallery.js:66: * @param {Object} context
Gallery context.
non-nullable

https://codereview.chromium.org/246543002/diff/60001/chrome/browser/resources...
chrome/browser/resources/gallery/js/gallery.js:131: * @param {Event} event The
unmount event.
non-nullable

https://codereview.chromium.org/246543002/diff/60001/chrome/browser/resources...
chrome/browser/resources/gallery/js/gallery.js:268: * @return {HTMLElement}
Newly created button.
non-nullable

https://codereview.chromium.org/246543002/diff/60001/chrome/browser/resources...
chrome/browser/resources/gallery/js/gallery.js:280: * @param {Array.<Entry>}
entries Array of entries.
non-nullable

https://codereview.chromium.org/246543002/diff/60001/chrome/browser/resources...
chrome/browser/resources/gallery/js/gallery.js:320:
this.context_.pageState.gallery === 'mosaic');
4 space

https://codereview.chromium.org/246543002/diff/60001/chrome/browser/resources...
chrome/browser/resources/gallery/js/gallery.js:469:
this.slideMode_.leave(tileRect,
new line before the first argument.

https://codereview.chromium.org/246543002/diff/60001/chrome/browser/resources...
chrome/browser/resources/gallery/js/gallery.js:478:
this.slideMode_.enter(tileRect,
new line before the first argument.

https://codereview.chromium.org/246543002/diff/60001/chrome/browser/resources...
chrome/browser/resources/gallery/js/gallery.js:566: throw new Error('Unexpected
multiple selection');
I think passing an exception is not good idea. Could you return null and handle
the error in caller?

https://codereview.chromium.org/246543002/diff/60001/chrome/browser/resources...
chrome/browser/resources/gallery/js/gallery.js:893:
trackPromise(window.backgroundComponent.then(
I think, it's better to handle the reject here explicitly, rather than using
trackPromise. I think the caller should decide how to treat the error as
case-by-case (of cause, either ignoring the error or just writing a log is ok)
and the code handing error should be in the caller. And I think there is no
advantage of trackPromise as a shorthand expression.

[hirono, 2014-04-23 08:13:15]

Thank you!

https://codereview.chromium.org/246543002/diff/60001/chrome/browser/resources...
File
chrome/browser/resources/file_manager/foreground/js/metadata/metadata_cache.js
(right):

https://codereview.chromium.org/246543002/diff/60001/chrome/browser/resources...
chrome/browser/resources/file_manager/foreground/js/metadata/metadata_cache.js:879:
dispatcher.start();
On 2014/04/23 07:08:39, yoshiki wrote:
> I think, it's better to put start() after adding message handler.

Done.

https://codereview.chromium.org/246543002/diff/60001/chrome/browser/resources...
chrome/browser/resources/file_manager/foreground/js/metadata/metadata_cache.js:895:
* @type {string}
On 2014/04/23 07:08:39, yoshiki wrote:
> @const

Done.

https://codereview.chromium.org/246543002/diff/60001/chrome/browser/resources...
File chrome/browser/resources/file_manager/manifest.json (right):

https://codereview.chromium.org/246543002/diff/60001/chrome/browser/resources...
chrome/browser/resources/file_manager/manifest.json:198:
"foreground/js/metadata/*.js"
On 2014/04/23 07:08:39, yoshiki wrote:
> Could you move the follwoing file/directory into common/?
> - foreground/js/metadata
> - background/js/test_util.js
> 
> I think 'common' is better place.

Previously 'common' means the assets are shared by foreground and background.
I think ui/file_manager/common is the better place.
WDYT?

https://codereview.chromium.org/246543002/diff/60001/chrome/browser/resources...
File chrome/browser/resources/gallery/gallery.html (right):

https://codereview.chromium.org/246543002/diff/60001/chrome/browser/resources...
chrome/browser/resources/gallery/gallery.html:8: <meta
http-equiv="Content-Security-Policy" content="script-src chrome-extension://;">
On 2014/04/23 07:08:39, yoshiki wrote:
> Could you specify this policy in manifest.json, instead of here?
> 
> chrome-extension:// is not safe. Please specify the extension ID in addition. 

Oops, this is a debug line. Removed.

https://codereview.chromium.org/246543002/diff/60001/chrome/browser/resources...
File chrome/browser/resources/gallery/js/gallery.js (right):

https://codereview.chromium.org/246543002/diff/60001/chrome/browser/resources...
chrome/browser/resources/gallery/js/gallery.js:23: * @param {VolumeManager}
volumeManager The VolumeManager instance of the
On 2014/04/23 07:08:39, yoshiki wrote:
> non-nullable

Done.

https://codereview.chromium.org/246543002/diff/60001/chrome/browser/resources...
chrome/browser/resources/gallery/js/gallery.js:24: *      system.
On 2014/04/23 07:08:39, yoshiki wrote:
> 4 space indent.

Done.

https://codereview.chromium.org/246543002/diff/60001/chrome/browser/resources...
chrome/browser/resources/gallery/js/gallery.js:30: appWindow:
chrome.app.window.current(),
On 2014/04/23 07:08:39, yoshiki wrote:
> 4 space indent.

2 space looks OK according to the style guide.
https://google-styleguide.googlecode.com/svn/trunk/javascriptguide.xml?showon...

https://codereview.chromium.org/246543002/diff/60001/chrome/browser/resources...
chrome/browser/resources/gallery/js/gallery.js:66: * @param {Object} context
Gallery context.
On 2014/04/23 07:08:39, yoshiki wrote:
> non-nullable

Removed the method itself.

https://codereview.chromium.org/246543002/diff/60001/chrome/browser/resources...
chrome/browser/resources/gallery/js/gallery.js:131: * @param {Event} event The
unmount event.
On 2014/04/23 07:08:39, yoshiki wrote:
> non-nullable

Done.

https://codereview.chromium.org/246543002/diff/60001/chrome/browser/resources...
chrome/browser/resources/gallery/js/gallery.js:268: * @return {HTMLElement}
Newly created button.
On 2014/04/23 07:08:39, yoshiki wrote:
> non-nullable

Done.

https://codereview.chromium.org/246543002/diff/60001/chrome/browser/resources...
chrome/browser/resources/gallery/js/gallery.js:280: * @param {Array.<Entry>}
entries Array of entries.
On 2014/04/23 07:08:39, yoshiki wrote:
> non-nullable

Done.

https://codereview.chromium.org/246543002/diff/60001/chrome/browser/resources...
chrome/browser/resources/gallery/js/gallery.js:320:
this.context_.pageState.gallery === 'mosaic');
On 2014/04/23 07:08:39, yoshiki wrote:
> 4 space

Done.

https://codereview.chromium.org/246543002/diff/60001/chrome/browser/resources...
chrome/browser/resources/gallery/js/gallery.js:469:
this.slideMode_.leave(tileRect,
On 2014/04/23 07:08:39, yoshiki wrote:
> new line before the first argument.

Done.

https://codereview.chromium.org/246543002/diff/60001/chrome/browser/resources...
chrome/browser/resources/gallery/js/gallery.js:478:
this.slideMode_.enter(tileRect,
On 2014/04/23 07:08:39, yoshiki wrote:
> new line before the first argument.

Done.

https://codereview.chromium.org/246543002/diff/60001/chrome/browser/resources...
chrome/browser/resources/gallery/js/gallery.js:566: throw new Error('Unexpected
multiple selection');
On 2014/04/23 07:08:39, yoshiki wrote:
> I think passing an exception is not good idea. Could you return null and
handle
> the error in caller?

Done.

https://codereview.chromium.org/246543002/diff/60001/chrome/browser/resources...
chrome/browser/resources/gallery/js/gallery.js:893:
trackPromise(window.backgroundComponent.then(
On 2014/04/23 07:08:39, yoshiki wrote:
> I think, it's better to handle the reject here explicitly, rather than using
> trackPromise. I think the caller should decide how to treat the error as
> case-by-case (of cause, either ignoring the error or just writing a log is ok)
> and the code handing error should be in the caller. And I think there is no
> advantage of trackPromise as a shorthand expression.

Done.

[yoshiki, 2014-04-24 03:49:40]

https://codereview.chromium.org/246543002/diff/60001/chrome/browser/resources...
File chrome/browser/resources/file_manager/manifest.json (right):

https://codereview.chromium.org/246543002/diff/60001/chrome/browser/resources...
chrome/browser/resources/file_manager/manifest.json:198:
"foreground/js/metadata/*.js"
On 2014/04/23 08:13:15, hirono wrote:
> On 2014/04/23 07:08:39, yoshiki wrote:
> > Could you move the follwoing file/directory into common/?
> > - foreground/js/metadata
> > - background/js/test_util.js
> > 
> > I think 'common' is better place.
> 
> Previously 'common' means the assets are shared by foreground and background.
> I think ui/file_manager/common is the better place.
> WDYT?
> 

ui/file_manager/common can't be accessible by app. I think
ui/file_manager/file_manager/common/ is enough. Originally this directory has
been for the code used by both, but I think using for shared files among apps is
fine. But as for now, keeping the file place as they are (and considering about
this separately) is also ok.

And could you specify each script name, instead of using asterisk?

[hirono, 2014-04-24 05:11:15]

Thank you!

https://codereview.chromium.org/246543002/diff/60001/chrome/browser/resources...
File chrome/browser/resources/file_manager/manifest.json (right):

https://codereview.chromium.org/246543002/diff/60001/chrome/browser/resources...
chrome/browser/resources/file_manager/manifest.json:198:
"foreground/js/metadata/*.js"
On 2014/04/24 03:49:40, yoshiki wrote:
> On 2014/04/23 08:13:15, hirono wrote:
> > On 2014/04/23 07:08:39, yoshiki wrote:
> > > Could you move the follwoing file/directory into common/?
> > > - foreground/js/metadata
> > > - background/js/test_util.js
> > > 
> > > I think 'common' is better place.
> > 
> > Previously 'common' means the assets are shared by foreground and
background.
> > I think ui/file_manager/common is the better place.
> > WDYT?
> > 
> 
> ui/file_manager/common can't be accessible by app. I think
> ui/file_manager/file_manager/common/ is enough. Originally this directory has
> been for the code used by both, but I think using for shared files among apps
is
> fine. But as for now, keeping the file place as they are (and considering
about
> this separately) is also ok.
> 
> And could you specify each script name, instead of using asterisk?

So let me keep the structure as it is. I'm also think of the structure like:
file_manager/js/foreground. The original reason why we put the foreground just
under the file_manager is we might have sub-components such as video_player
under the foreground directory.
https://codereview.chromium.org/39123003/#msg2

Maybe we can simplify the directory structure.

[yoshiki, 2014-04-24 10:09:19]

lgtm

https://codereview.chromium.org/246543002/diff/60001/chrome/browser/resources...
File chrome/browser/resources/file_manager/manifest.json (right):

https://codereview.chromium.org/246543002/diff/60001/chrome/browser/resources...
chrome/browser/resources/file_manager/manifest.json:198:
"foreground/js/metadata/*.js"
On 2014/04/24 05:11:15, hirono wrote:
> On 2014/04/24 03:49:40, yoshiki wrote:
> > On 2014/04/23 08:13:15, hirono wrote:
> > > On 2014/04/23 07:08:39, yoshiki wrote:
> > > > Could you move the follwoing file/directory into common/?
> > > > - foreground/js/metadata
> > > > - background/js/test_util.js
> > > > 
> > > > I think 'common' is better place.
> > > 
> > > Previously 'common' means the assets are shared by foreground and
> background.
> > > I think ui/file_manager/common is the better place.
> > > WDYT?
> > > 
> > 
> > ui/file_manager/common can't be accessible by app. I think
> > ui/file_manager/file_manager/common/ is enough. Originally this directory
has
> > been for the code used by both, but I think using for shared files among
apps
> is
> > fine. But as for now, keeping the file place as they are (and considering
> about
> > this separately) is also ok.
> > 
> > And could you specify each script name, instead of using asterisk?
> 
> So let me keep the structure as it is. I'm also think of the structure like:
> file_manager/js/foreground. The original reason why we put the foreground just
> under the file_manager is we might have sub-components such as video_player
> under the foreground directory.
> https://codereview.chromium.org/39123003/#msg2
> 
> Maybe we can simplify the directory structure.

sgtm

[hirono, 2014-04-24 10:10:00]

The CQ bit was checked by hirono@chromium.org

[commit-bot: I haz the power, 2014-04-24 11:08:08]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/hirono@chromium.org/246543002/120001

[commit-bot: I haz the power, 2014-04-24 11:44:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-24 11:44:24]

Try jobs failed on following builders:
  tryserver.chromium on chromium_presubmit

[hirono, 2014-04-25 06:19:04]

The CQ bit was checked by hirono@chromium.org

[commit-bot: I haz the power, 2014-04-25 07:37:19]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/hirono@chromium.org/246543002/150001

[commit-bot: I haz the power, 2014-04-25 08:40:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-25 08:40:21]

Try jobs failed on following builders:
  tryserver.chromium on chromium_presubmit

[hirono, 2014-04-27 08:32:47]

The CQ bit was checked by hirono@chromium.org

[commit-bot: I haz the power, 2014-04-27 08:33:38]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/hirono@chromium.org/246543002/150001

[commit-bot: I haz the power, 2014-04-27 08:38:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-27 08:38:48]

Try jobs failed on following builders:
  tryserver.chromium on chromium_presubmit

[hirono, 2014-04-28 02:25:16]

The CQ bit was checked by hirono@chromium.org

[commit-bot: I haz the power, 2014-04-28 02:26:25]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/hirono@chromium.org/246543002/150001

[commit-bot: I haz the power, 2014-04-28 03:03:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-28 03:03:55]

Try jobs failed on following builders:
  tryserver.chromium on chromium_presubmit

[hirono, 2014-04-28 03:43:03]

The CQ bit was checked by hirono@chromium.org

[commit-bot: I haz the power, 2014-04-28 03:43:47]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/hirono@chromium.org/246543002/170001

[commit-bot: I haz the power, 2014-04-28 04:12:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-28 04:12:49]

Try jobs failed on following builders:
  tryserver.chromium on win_chromium_x64_rel

[hirono, 2014-04-28 04:14:08]

The CQ bit was checked by hirono@chromium.org

[commit-bot: I haz the power, 2014-04-28 04:15:31]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/hirono@chromium.org/246543002/170001

[commit-bot: I haz the power, 2014-04-28 04:30:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-28 04:30:21]

Try jobs failed on following builders:
  tryserver.chromium on chromium_presubmit

[hirono, 2014-04-28 06:01:13]

The CQ bit was checked by hirono@chromium.org

[commit-bot: I haz the power, 2014-04-28 06:01:39]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/hirono@chromium.org/246543002/210001

[commit-bot: I haz the power, 2014-04-28 07:01:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-28 07:01:55]

Try jobs failed on following builders:
  tryserver.chromium on linux_chromium_chromeos_rel

[hirono, 2014-04-28 07:28:03]

The CQ bit was checked by hirono@chromium.org

[commit-bot: I haz the power, 2014-04-28 07:28:48]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/hirono@chromium.org/246543002/210001

[commit-bot: I haz the power, 2014-04-28 09:05:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-28 09:05:43]

Try jobs failed on following builders:
  tryserver.chromium on win_chromium_rel

[hirono, 2014-04-28 09:06:56]

The CQ bit was checked by hirono@chromium.org

[commit-bot: I haz the power, 2014-04-28 09:13:49]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/hirono@chromium.org/246543002/210001

[commit-bot: I haz the power, 2014-04-28 10:08:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-28 10:08:58]

Try jobs failed on following builders:
  tryserver.chromium on win_chromium_rel

[hirono, 2014-04-28 10:11:19]

The CQ bit was checked by hirono@chromium.org

[commit-bot: I haz the power, 2014-04-28 10:11:56]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/hirono@chromium.org/246543002/210001

[commit-bot: I haz the power, 2014-04-28 12:40:07]

Change committed as 266531