Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(790)

Unified Diff: third_party/WebKit/Source/modules/sensor/Sensor.h

Issue 2465363004: [Sensors] Consider maximum supported frequency (Closed)
Patch Set: Comments from Alex Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/sensor/Sensor.h
diff --git a/third_party/WebKit/Source/modules/sensor/Sensor.h b/third_party/WebKit/Source/modules/sensor/Sensor.h
index e1aacf407cdb04730dc594e605b3498a1959e2bf..96fd346b3cd72392ad6f0fe4cfefd61cf2e5c254 100644
--- a/third_party/WebKit/Source/modules/sensor/Sensor.h
+++ b/third_party/WebKit/Source/modules/sensor/Sensor.h
@@ -70,9 +70,11 @@ class Sensor : public EventTargetWithInlineData,
using SensorConfigurationPtr = device::mojom::blink::SensorConfigurationPtr;
using SensorConfiguration = device::mojom::blink::SensorConfiguration;
- virtual SensorConfigurationPtr createSensorConfig(
- const SensorOptions&,
- const SensorConfiguration& defaultConfiguration) = 0;
+
+ // The default implementation will init frequency configuration parameter,
+ // concrete sensor implementations can override this method to handle other
+ // parameters if needed.
+ virtual SensorConfigurationPtr createSensorConfig();
private:
void initSensorProxyIfNeeded();

Powered by Google App Engine
This is Rietveld 408576698