Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(894)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: device/generic_sensor/platform_sensor.h

Issue 2465363004: [Sensors] Consider maximum supported frequency (Closed)
Patch Set: Comments from Alex Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« device/generic_sensor/android/java/src/org/chromium/device/sensors/PlatformSensor.java ('K') | « device/generic_sensor/android/junit/src/org/chromium/device/sensors/PlatformSensorAndProviderTest.java ('k') | device/generic_sensor/platform_sensor.cc » ('j') | device/generic_sensor/platform_sensor_and_provider_unittest_win.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: device/generic_sensor/platform_sensor.h
diff --git a/device/generic_sensor/platform_sensor.h b/device/generic_sensor/platform_sensor.h
index 0a2948ffb48b63989dd92509b602b730ebf7735c..697bbd209d1276303fe6dd12bc614652939e4a3e 100644
--- a/device/generic_sensor/platform_sensor.h
+++ b/device/generic_sensor/platform_sensor.h
@@ -41,6 +41,13 @@ class DEVICE_GENERIC_SENSOR_EXPORT PlatformSensor
virtual mojom::ReportingMode GetReportingMode() = 0;
virtual PlatformSensorConfiguration GetDefaultConfiguration() = 0;
+ // Can be overriden to return the sensor maximum sampling frequency
+ // value obtained from the platfrom if it is available. If platfrom
timvolodine 2016/11/03 17:32:56 platfrom->platform
Mikhail 2016/11/04 21:17:44 Done.
+ // does not provide maximum sampling frequency this method must
+ // return default frequency.
+ // The default implementation returns default frequency.
+ virtual double GetMaximumSupportedFrequency();
timvolodine 2016/11/03 17:32:56 const? (or is that too restrictive?)
Mikhail 2016/11/04 21:17:44 would not like to put such a limit for implementat
+
mojom::SensorType GetType() const;
bool StartListening(Client* client,
« device/generic_sensor/android/java/src/org/chromium/device/sensors/PlatformSensor.java ('K') | « device/generic_sensor/android/junit/src/org/chromium/device/sensors/PlatformSensorAndProviderTest.java ('k') | device/generic_sensor/platform_sensor.cc » ('j') | device/generic_sensor/platform_sensor_and_provider_unittest_win.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698