Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(780)

Unified Diff: device/generic_sensor/platform_sensor.h

Issue 2465363004: [Sensors] Consider maximum supported frequency (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: device/generic_sensor/platform_sensor.h
diff --git a/device/generic_sensor/platform_sensor.h b/device/generic_sensor/platform_sensor.h
index 0a2948ffb48b63989dd92509b602b730ebf7735c..d4785f2978c46c87f7074e4979ba716ea0baaaa6 100644
--- a/device/generic_sensor/platform_sensor.h
+++ b/device/generic_sensor/platform_sensor.h
@@ -41,6 +41,12 @@ class DEVICE_GENERIC_SENSOR_EXPORT PlatformSensor
virtual mojom::ReportingMode GetReportingMode() = 0;
virtual PlatformSensorConfiguration GetDefaultConfiguration() = 0;
+ // Can be overriden to return the sensor maximum reading update frequency
+ // value obtained from the platfrom.
+ // If this information is unavailable '0.0' is returned.
darktears 2016/11/02 23:06:09 This sounds weird. I mean I would expect the defau
Mikhail 2016/11/03 12:13:17 I'm not sure we should confuse device capabilities
+ // The default implemenmtation returns '0.0'.
darktears 2016/11/02 23:06:09 Typo here.
Mikhail 2016/11/03 12:13:17 Done.
+ virtual double GetMaximumSupportedFrequency();
+
mojom::SensorType GetType() const;
bool StartListening(Client* client,

Powered by Google App Engine
This is Rietveld 408576698