Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(920)

Unified Diff: third_party/WebKit/Source/modules/sensor/AmbientLightSensor.cpp

Issue 2465363004: [Sensors] Consider maximum supported frequency (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/sensor/AmbientLightSensor.cpp
diff --git a/third_party/WebKit/Source/modules/sensor/AmbientLightSensor.cpp b/third_party/WebKit/Source/modules/sensor/AmbientLightSensor.cpp
index d124044da0da34ae8f0c2c8eaf7bbddf38d6fb9a..bb43f119d2be3c6f86c5524ee62560e38c792035 100644
--- a/third_party/WebKit/Source/modules/sensor/AmbientLightSensor.cpp
+++ b/third_party/WebKit/Source/modules/sensor/AmbientLightSensor.cpp
@@ -40,10 +40,16 @@ SensorReading* AmbientLightSensor::createSensorReading(SensorProxy* proxy) {
auto AmbientLightSensor::createSensorConfig(
const SensorOptions& options,
- const SensorConfiguration& defaultConfig) -> SensorConfigurationPtr {
+ const SensorConfiguration& defaultConfig,
+ double maxSupportedFrequency) -> SensorConfigurationPtr {
auto result = device::mojom::blink::SensorConfiguration::New();
- result->frequency =
+ double frequency =
options.hasFrequency() ? options.frequency() : defaultConfig.frequency;
+
+ if (maxSupportedFrequency && frequency > maxSupportedFrequency)
shalamov 2016/11/02 14:42:45 Can this be moved to Sensor or another place, so t
+ frequency = maxSupportedFrequency;
+
+ result->frequency = frequency;
return result;
}

Powered by Google App Engine
This is Rietveld 408576698