[DevTools] migrate RenderingAgent and EmulationAgent to new style

[DevTools] migrate RenderingAgent and EmulationAgent to new style

Replace in header:
void ([a-zA-Z]+)\(\s*ErrorString\*(?: error(?:String)?)?,? ?
Response \1(

Replace in implementation:
void ([a-zA-Z]+)::([a-zA-Z]+)\(\s*ErrorString\*(?: error(?:String)?)?,? ?
Response \1::\2(

Replace in header and implementation:
const (?:protocol::)?Maybe<([^>]+)>&
Maybe<\1>

Remove in implementation:
&error,? ?

Replace in implementation:
\*error(?:String)? = ("[^"]+");\s+return;
return Response::Error(\1);

Added return Response::OK at the end of functions.

BUG=none
R=dgozman@chromium.org

Committed: https://crrev.com/bebd3b443427ad8e03dd26d901060abe35354140
Cr-Commit-Position: refs/heads/master@{#429195}

[kozy, 2016-11-01 17:22:50]

Dmitry, please take a look.

[kozy, 2016-11-01 17:25:17]

Description was changed from

==========
[DevTools] migrate RenderingAgent and EmulationAgent to new style

Replace in header:
void ([a-zA-Z]+)::([a-zA-Z]+)\(\s*ErrorString\*(?: error(?:String)?)?,? ?
Response \1::\2(

Replace in header and implementation:
const (?:protocol::)?Maybe<([^>]+)>&
Maybe<\1>

Remove in implementation:
&error,? ?

Replace in implementation:
\*error(?:String)? = ("[^"]+");\s+return;
return Response::Error(\1);

Added return Response::OK at the end of functions.

BUG=none
R=dgozman@chromium.org
==========

to

==========
[DevTools] migrate RenderingAgent and EmulationAgent to new style

Replace in header:
void ([a-zA-Z]+)\(\s*ErrorString\*(?: error(?:String)?)?,? ?
Response \1::\2(

Replace in implementation:
void ([a-zA-Z]+)::([a-zA-Z]+)\(\s*ErrorString\*(?: error(?:String)?)?,? ?
Response \1::\2(

Replace in header and implementation:
const (?:protocol::)?Maybe<([^>]+)>&
Maybe<\1>

Remove in implementation:
&error,? ?

Replace in implementation:
\*error(?:String)? = ("[^"]+");\s+return;
return Response::Error(\1);

Added return Response::OK at the end of functions.

BUG=none
R=dgozman@chromium.org
==========

[kozy, 2016-11-01 17:26:37]

Description was changed from

==========
[DevTools] migrate RenderingAgent and EmulationAgent to new style

Replace in header:
void ([a-zA-Z]+)\(\s*ErrorString\*(?: error(?:String)?)?,? ?
Response \1::\2(

Replace in implementation:
void ([a-zA-Z]+)::([a-zA-Z]+)\(\s*ErrorString\*(?: error(?:String)?)?,? ?
Response \1::\2(

Replace in header and implementation:
const (?:protocol::)?Maybe<([^>]+)>&
Maybe<\1>

Remove in implementation:
&error,? ?

Replace in implementation:
\*error(?:String)? = ("[^"]+");\s+return;
return Response::Error(\1);

Added return Response::OK at the end of functions.

BUG=none
R=dgozman@chromium.org
==========

to

==========
[DevTools] migrate RenderingAgent and EmulationAgent to new style

Replace in header:
void ([a-zA-Z]+)\(\s*ErrorString\*(?: error(?:String)?)?,? ?
Response \1(

Replace in implementation:
void ([a-zA-Z]+)::([a-zA-Z]+)\(\s*ErrorString\*(?: error(?:String)?)?,? ?
Response \1::\2(

Replace in header and implementation:
const (?:protocol::)?Maybe<([^>]+)>&
Maybe<\1>

Remove in implementation:
&error,? ?

Replace in implementation:
\*error(?:String)? = ("[^"]+");\s+return;
return Response::Error(\1);

Added return Response::OK at the end of functions.

BUG=none
R=dgozman@chromium.org
==========

[dgozman, 2016-11-01 18:44:18]

lgtm

[kozy, 2016-11-02 01:34:50]

The CQ bit was checked by kozyatinskiy@chromium.org

[kozy, 2016-11-02 01:34:51]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/2465343002/#ps20001
(title: "rebased")

[commit-bot: I haz the power, 2016-11-02 01:35:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-02 03:02:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-02 03:02:47]

Failed to apply the patch.
On branch working_branch
Your branch is up-to-date with 'origin/refs/pending/heads/master'.
nothing to commit, working tree clean

[commit-bot: I haz the power, 2016-11-02 03:05:24]

Description was changed from

==========
[DevTools] migrate RenderingAgent and EmulationAgent to new style

Replace in header:
void ([a-zA-Z]+)\(\s*ErrorString\*(?: error(?:String)?)?,? ?
Response \1(

Replace in implementation:
void ([a-zA-Z]+)::([a-zA-Z]+)\(\s*ErrorString\*(?: error(?:String)?)?,? ?
Response \1::\2(

Replace in header and implementation:
const (?:protocol::)?Maybe<([^>]+)>&
Maybe<\1>

Remove in implementation:
&error,? ?

Replace in implementation:
\*error(?:String)? = ("[^"]+");\s+return;
return Response::Error(\1);

Added return Response::OK at the end of functions.

BUG=none
R=dgozman@chromium.org
==========

to

==========
[DevTools] migrate RenderingAgent and EmulationAgent to new style

Replace in header:
void ([a-zA-Z]+)\(\s*ErrorString\*(?: error(?:String)?)?,? ?
Response \1(

Replace in implementation:
void ([a-zA-Z]+)::([a-zA-Z]+)\(\s*ErrorString\*(?: error(?:String)?)?,? ?
Response \1::\2(

Replace in header and implementation:
const (?:protocol::)?Maybe<([^>]+)>&
Maybe<\1>

Remove in implementation:
&error,? ?

Replace in implementation:
\*error(?:String)? = ("[^"]+");\s+return;
return Response::Error(\1);

Added return Response::OK at the end of functions.

BUG=none
R=dgozman@chromium.org

Committed: https://crrev.com/bebd3b443427ad8e03dd26d901060abe35354140
Cr-Commit-Position: refs/heads/master@{#429195}
==========

[commit-bot: I haz the power, 2016-11-02 03:05:24]

Patchset 2 (id:??) landed as
https://crrev.com/bebd3b443427ad8e03dd26d901060abe35354140
Cr-Commit-Position: refs/heads/master@{#429195}