Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 2465153002: gpu: Remove some GpuProcessHost dependency from shader cache. (Closed)

Created:
4 years, 1 month ago by sadrul
Modified:
4 years, 1 month ago
Reviewers:
piman
CC:
chromium-reviews, jam, darin-cc_chromium.org, piman+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

gpu: Remove some GpuProcessHost dependency from shader cache. Install a callback in ShaderDiskCache from GpuProcessHost to run when shader data is loaded from the cache. This removes one of the content dependencies from the shader cache code. A subsequent CL will remove the dependency on BrowserThread, and then the shader cache code can move out of content so that it can be shared with services/ui. BUG=643746 Committed: https://crrev.com/25360f4fcff36a27834a5735fde5661f06bf668f Cr-Commit-Position: refs/heads/master@{#429015}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -19 lines) Patch
M content/browser/gpu/gpu_process_host.cc View 2 chunks +9 lines, -1 line 0 comments Download
M content/browser/gpu/shader_disk_cache.h View 2 chunks +6 lines, -2 lines 0 comments Download
M content/browser/gpu/shader_disk_cache.cc View 7 chunks +12 lines, -16 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 12 (7 generated)
sadrul
4 years, 1 month ago (2016-11-01 13:29:21 UTC) #6
piman
lgtm
4 years, 1 month ago (2016-11-01 15:54:49 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2465153002/1
4 years, 1 month ago (2016-11-01 16:23:38 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-01 16:28:39 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-11-01 17:22:14 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/25360f4fcff36a27834a5735fde5661f06bf668f
Cr-Commit-Position: refs/heads/master@{#429015}

Powered by Google App Engine
This is Rietveld 408576698