Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 2464973002: [profiler] Make certain Runtime Call Stats fields atomic. (Closed)

Created:
4 years, 1 month ago by alph
Modified:
4 years, 1 month ago
Reviewers:
caseq, lpy, Camillo Bruni
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[profiler] Make certain Runtime Call Stats fields atomic. Make RuntimeCallTimer::parent_ and RuntimeCallStats::current_timer_ fields atomic as they are accessed from the signal handler. BUG=chromium:660428 Committed: https://crrev.com/fdca1bb2da9783c3362277b3a9a9e5cb9bf2178e Cr-Commit-Position: refs/heads/master@{#40709}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -25 lines) Patch
M src/counters.h View 4 chunks +12 lines, -12 lines 0 comments Download
M src/counters.cc View 2 chunks +13 lines, -13 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
alph
ptal
4 years, 1 month ago (2016-10-31 18:49:05 UTC) #2
lpy
LGTM from my side.
4 years, 1 month ago (2016-10-31 19:40:40 UTC) #7
caseq
lgtm
4 years, 1 month ago (2016-10-31 20:43:28 UTC) #8
Camillo Bruni
LGTM
4 years, 1 month ago (2016-11-02 10:26:57 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2464973002/1
4 years, 1 month ago (2016-11-02 17:23:34 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-02 18:49:53 UTC) #12
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:19:49 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fdca1bb2da9783c3362277b3a9a9e5cb9bf2178e
Cr-Commit-Position: refs/heads/master@{#40709}

Powered by Google App Engine
This is Rietveld 408576698