[profiler] Make certain Runtime Call Stats fields atomic.

src/counters.cc

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/counters.h"
 
 #include <iomanip>
 
 #include "src/base/platform/platform.h"
 #include "src/isolate.h"
@@ skipping 270 matching lines @@
   value->BeginArray(name);
   value->AppendLongInteger(count);
   value->AppendLongInteger(time.InMicroseconds());
   value->EndArray();
 }
 
 // static
 void RuntimeCallStats::Enter(RuntimeCallStats* stats, RuntimeCallTimer* timer,
                              CounterId counter_id) {
   RuntimeCallCounter* counter = &(stats->*counter_id);
-  timer->Start(counter, stats->current_timer_);
-  stats->current_timer_ = timer;
+  timer->Start(counter, stats->current_timer_.Value());
+  stats->current_timer_.SetValue(timer);
 }
 
 // static
 void RuntimeCallStats::Leave(RuntimeCallStats* stats, RuntimeCallTimer* timer) {
-  if (stats->current_timer_ == timer) {
-    stats->current_timer_ = timer->Stop();
+  if (stats->current_timer_.Value() == timer) {
+    stats->current_timer_.SetValue(timer->Stop());
   } else {
     // Must be a Threading cctest. Walk the chain of Timers to find the
     // buried one that's leaving. We don't care about keeping nested timings
     // accurate, just avoid crashing by keeping the chain intact.
-    RuntimeCallTimer* next = stats->current_timer_;
-    while (next->parent_ != timer) next = next->parent_;
-    next->parent_ = timer->Stop();
+    RuntimeCallTimer* next = stats->current_timer_.Value();
+    while (next->parent() != timer) next = next->parent();
+    next->parent_.SetValue(timer->Stop());
   }
 }
 
 // static
 void RuntimeCallStats::CorrectCurrentCounterId(RuntimeCallStats* stats,
                                                CounterId counter_id) {
-  DCHECK_NOT_NULL(stats->current_timer_);
+  DCHECK_NOT_NULL(stats->current_timer_.Value());
   RuntimeCallCounter* counter = &(stats->*counter_id);
-  stats->current_timer_->counter_ = counter;
+  stats->current_timer_.Value()->counter_ = counter;
 }
 
 void RuntimeCallStats::Print(std::ostream& os) {
   RuntimeCallStatEntries entries;
-  if (current_timer_ != NULL) {
-    current_timer_->Elapsed();
+  if (current_timer_.Value() != nullptr) {
+    current_timer_.Value()->Elapsed();
   }
 
 #define PRINT_COUNTER(name) entries.Add(&this->name);
   FOR_EACH_MANUAL_COUNTER(PRINT_COUNTER)
 #undef PRINT_COUNTER
 
 #define PRINT_COUNTER(name, nargs, ressize) entries.Add(&this->Runtime_##name);
   FOR_EACH_INTRINSIC(PRINT_COUNTER)
 #undef PRINT_COUNTER
 
@@ skipping 31 matching lines @@
 #undef RESET_COUNTER
 
 #define RESET_COUNTER(name) this->Handler_##name.Reset();
   FOR_EACH_HANDLER_COUNTER(RESET_COUNTER)
 #undef RESET_COUNTER
 
   in_use_ = true;
 }
 
 void RuntimeCallStats::Dump(v8::tracing::TracedValue* value) {
-  if (current_timer_ != NULL) {
-    current_timer_->Elapsed();
+  if (current_timer_.Value() != nullptr) {
+    current_timer_.Value()->Elapsed();
   }
 #define DUMP_COUNTER(name) \
   if (this->name.count > 0) this->name.Dump(value);
   FOR_EACH_MANUAL_COUNTER(DUMP_COUNTER)
 #undef DUMP_COUNTER
 
 #define DUMP_COUNTER(name, nargs, result_size) \
   if (this->Runtime_##name.count > 0) this->Runtime_##name.Dump(value);
   FOR_EACH_INTRINSIC(DUMP_COUNTER)
 #undef DUMP_COUNTER
@@ skipping 11 matching lines @@
 #define DUMP_COUNTER(name) \
   if (this->Handler_##name.count > 0) this->Handler_##name.Dump(value);
   FOR_EACH_HANDLER_COUNTER(DUMP_COUNTER)
 #undef DUMP_COUNTER
 
   in_use_ = false;
 }
 
 }  // namespace internal
 }  // namespace v8