Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2464943002: Componentize CrashFileManager and MinidumpUploadCallable. (Closed)

Created:
4 years, 1 month ago by gsennton
Modified:
4 years, 1 month ago
Reviewers:
Ilya Sherman, Maria
CC:
chromium-reviews, kalyank, sadrul, asvitkine+watch_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Componentize CrashFileManager and MinidumpUploadCallable. And their respective test classes. BUG=652719 Committed: https://crrev.com/4149f24d84bba28ca806ab77635963c3d02c4040 Cr-Commit-Position: refs/heads/master@{#430167}

Patch Set 1 #

Patch Set 2 : Rebase #

Total comments: 2

Patch Set 3 : Update copyright year of moved files. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -1761 lines) Patch
M chrome/android/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/DeferredStartupHandler.java View 2 chunks +1 line, -1 line 0 comments Download
D chrome/android/java/src/org/chromium/chrome/browser/crash/CrashFileManager.java View 1 chunk +0 lines, -387 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/crash/LogcatExtractionCallable.java View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/crash/MinidumpDirectoryObserver.java View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/crash/MinidumpPreparationCallable.java View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/crash/MinidumpPreparationService.java View 1 chunk +1 line, -0 lines 0 comments Download
D chrome/android/java/src/org/chromium/chrome/browser/crash/MinidumpUploadCallable.java View 1 chunk +0 lines, -319 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/crash/MinidumpUploadService.java View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/android/java_sources.gni View 1 2 chunks +0 lines, -5 lines 0 comments Download
D chrome/android/javatests/src/org/chromium/chrome/browser/crash/CrashFileManagerTest.java View 1 chunk +0 lines, -423 lines 0 comments Download
D chrome/android/javatests/src/org/chromium/chrome/browser/crash/CrashTestCase.java View 1 chunk +0 lines, -84 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/crash/LogcatExtractionCallableTest.java View 1 chunk +2 lines, -0 lines 0 comments Download
D chrome/android/javatests/src/org/chromium/chrome/browser/crash/MinidumpUploadCallableTest.java View 1 1 chunk +0 lines, -522 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/crash/MinidumpUploadServiceTest.java View 1 chunk +3 lines, -0 lines 0 comments Download
M components/minidump_uploader/BUILD.gn View 1 chunk +16 lines, -0 lines 0 comments Download
A + components/minidump_uploader/android/java/src/org/chromium/components/minidump_uploader/CrashFileManager.java View 1 2 7 chunks +21 lines, -11 lines 0 comments Download
A + components/minidump_uploader/android/java/src/org/chromium/components/minidump_uploader/MinidumpUploadCallable.java View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
A + components/minidump_uploader/android/javatests/src/org/chromium/components/minidump_uploader/CrashFileManagerTest.java View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
A + components/minidump_uploader/android/javatests/src/org/chromium/components/minidump_uploader/CrashTestCase.java View 1 2 1 chunk +4 lines, -3 lines 0 comments Download
A + components/minidump_uploader/android/javatests/src/org/chromium/components/minidump_uploader/MinidumpUploadCallableTest.java View 1 2 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
gsennton
ptal I'll rebase this after https://codereview.chromium.org/2464823002/ has been landed :) (so you might prefer reviewing ...
4 years, 1 month ago (2016-10-31 16:46:03 UTC) #2
Ilya Sherman
LGTM, thanks.
4 years, 1 month ago (2016-10-31 19:52:49 UTC) #3
gsennton
I never landed https://codereview.chromium.org/2464823002/ (doesn't seem worth it) but I rebased this now. Ptal :)
4 years, 1 month ago (2016-11-04 09:40:50 UTC) #4
Maria
lgtm https://codereview.chromium.org/2464943002/diff/20001/components/minidump_uploader/android/java/src/org/chromium/components/minidump_uploader/CrashFileManager.java File components/minidump_uploader/android/java/src/org/chromium/components/minidump_uploader/CrashFileManager.java (right): https://codereview.chromium.org/2464943002/diff/20001/components/minidump_uploader/android/java/src/org/chromium/components/minidump_uploader/CrashFileManager.java#newcode1 components/minidump_uploader/android/java/src/org/chromium/components/minidump_uploader/CrashFileManager.java:1: // Copyright 2015 The Chromium Authors. All rights ...
4 years, 1 month ago (2016-11-04 21:39:53 UTC) #5
Ilya Sherman
(Still LGTM)
4 years, 1 month ago (2016-11-05 01:21:14 UTC) #6
gsennton
Thanks (especially to Maria for looking at the CL while being sick. Get better soon!). ...
4 years, 1 month ago (2016-11-05 13:34:46 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2464943002/40001
4 years, 1 month ago (2016-11-05 13:35:36 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 1 month ago (2016-11-05 15:00:14 UTC) #11
commit-bot: I haz the power
4 years, 1 month ago (2016-11-05 15:01:52 UTC) #13
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/4149f24d84bba28ca806ab77635963c3d02c4040
Cr-Commit-Position: refs/heads/master@{#430167}

Powered by Google App Engine
This is Rietveld 408576698