Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(275)

Unified Diff: components/minidump_uploader/android/java/src/org/chromium/components/minidump_uploader/CrashFileManager.java

Issue 2464943002: Componentize CrashFileManager and MinidumpUploadCallable. (Closed)
Patch Set: Update copyright year of moved files. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/minidump_uploader/android/java/src/org/chromium/components/minidump_uploader/CrashFileManager.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/crash/CrashFileManager.java b/components/minidump_uploader/android/java/src/org/chromium/components/minidump_uploader/CrashFileManager.java
similarity index 95%
rename from chrome/android/java/src/org/chromium/chrome/browser/crash/CrashFileManager.java
rename to components/minidump_uploader/android/java/src/org/chromium/components/minidump_uploader/CrashFileManager.java
index f7c4679b3a2c2179a2c66aa8f9d95d44d717789c..0847c3f4efd758834930ef433b34f8ac9426ed4b 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/crash/CrashFileManager.java
+++ b/components/minidump_uploader/android/java/src/org/chromium/components/minidump_uploader/CrashFileManager.java
@@ -1,8 +1,8 @@
-// Copyright 2015 The Chromium Authors. All rights reserved.
+// Copyright 2016 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-package org.chromium.chrome.browser.crash;
+package org.chromium.components.minidump_uploader;
import android.support.annotation.Nullable;
@@ -32,12 +32,14 @@ import java.util.regex.Pattern;
public class CrashFileManager {
private static final String TAG = "CrashFileManager";
- @VisibleForTesting
- static final String CRASH_DUMP_DIR = "Crash Reports";
+ /**
+ * The name of the crash directory.
+ */
+ public static final String CRASH_DUMP_DIR = "Crash Reports";
// This should mirror the C++ CrashUploadList::kReporterLogFilename variable.
@VisibleForTesting
- static final String CRASH_DUMP_LOGFILE = "uploads.log";
+ public static final String CRASH_DUMP_LOGFILE = "uploads.log";
private static final Pattern MINIDUMP_FIRST_TRY_PATTERN =
Pattern.compile("\\.dmp([0-9]*)$\\z");
@@ -94,8 +96,10 @@ public class CrashFileManager {
}
};
- @VisibleForTesting
- static boolean deleteFile(File fileToDelete) {
+ /**
+ * Delete the file {@param fileToDelete}.
+ */
+ public static boolean deleteFile(File fileToDelete) {
boolean isSuccess = fileToDelete.delete();
if (!isSuccess) {
Log.w(TAG, "Unable to delete " + fileToDelete.getAbsolutePath());
@@ -329,7 +333,7 @@ public class CrashFileManager {
}
@VisibleForTesting
- File getCrashDirectory() {
+ public File getCrashDirectory() {
return new File(mCacheDir, CRASH_DUMP_DIR);
}
@@ -346,7 +350,10 @@ public class CrashFileManager {
return f;
}
- File getCrashFile(String filename) {
+ /**
+ * @return the crash file named {@param filename}.
+ */
+ public File getCrashFile(String filename) {
return new File(getCrashDirectory(), filename);
}
@@ -358,7 +365,7 @@ public class CrashFileManager {
* @param localId The local ID of the crash report.
* @return The matching File, or null if no matching file is found.
*/
- File getCrashFileWithLocalId(String localId) {
+ public File getCrashFileWithLocalId(String localId) {
for (File f : listCrashFiles(null)) {
// Only match non-uploaded or previously skipped files. In particular, do not match
// successfully uploaded files; nor files which are not minidump files, such as logcat
@@ -377,7 +384,10 @@ public class CrashFileManager {
return null;
}
- File getCrashUploadLogFile() {
+ /**
+ * @return the file used for logging crash upload events.
+ */
+ public File getCrashUploadLogFile() {
return new File(getCrashDirectory(), CRASH_DUMP_LOGFILE);
}

Powered by Google App Engine
This is Rietveld 408576698