Clean up a few more unused globals.

Clean up a few more unused globals.

Found by clang's new -Wunused-const-variable.

BUG=290204
R=akalin@chromium.org, avi@chromium.org, isherman@chromium.org, jamesr@chromium.org, joi@chromium.org, sergeyu@chromium.org, sky@chromium.org, thestig@chromium.org, xhwang@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=225273

[Nico, 2013-09-25 19:44:08]

jamesr: cc/, webkit/
thestig: chrome/, printing/
joi: components/, content/ google_apis/ (google_apis/ needs more than 1 owner
btw)
piman: gpu/
sergeyu: jingle/, remoting/
xhwang: media/
akalin: sync/
sky: ui/

[akalin, 2013-09-25 19:45:51]

sync lgtm

[Sergey Ulanov, 2013-09-25 19:46:26]

lgtm

[sky, 2013-09-25 20:21:25]

LGTM

[Lei Zhang, 2013-09-25 20:25:59]

chrome/ lgtm

Make sure you don't break the official build.

https://codereview.chromium.org/24649002/diff/6001/chrome/common/omaha_query_...
File chrome/common/omaha_query_params/omaha_query_params.cc (right):

https://codereview.chromium.org/24649002/diff/6001/chrome/common/omaha_query_...
chrome/common/omaha_query_params/omaha_query_params.cc:57: const char
kChromeCrx[] = "chromecrx";
shouldn't kChromiumCrx be the else case?

[Nico, 2013-09-25 20:42:23]

Thanks!

https://codereview.chromium.org/24649002/diff/6001/chrome/common/omaha_query_...
File chrome/common/omaha_query_params/omaha_query_params.cc (right):

https://codereview.chromium.org/24649002/diff/6001/chrome/common/omaha_query_...
chrome/common/omaha_query_params/omaha_query_params.cc:57: const char
kChromeCrx[] = "chromecrx";
On 2013/09/25 20:26:01, Lei Zhang wrote:
> shouldn't kChromiumCrx be the else case?

Good point, done.

[Nico, 2013-09-25 20:55:17]

Since joi is out-of-timezone:

isherman: components/autofill/
avi: content/

[Avi (use Gerrit), 2013-09-25 20:59:24]

content lgtm

[xhwang, 2013-09-25 21:16:50]

https://codereview.chromium.org/24649002/diff/16001/chrome/renderer/media/chr...
File chrome/renderer/media/chrome_key_systems.cc (right):

https://codereview.chromium.org/24649002/diff/16001/chrome/renderer/media/chr...
chrome/renderer/media/chrome_key_systems.cc:39: #endif  //
defined(USE_PROPRIETARY_CODECS)
Are dropping "static" because it's static by default? At lease in media/ code we
still specify "static" all over the place. Shall the "be consistent with
existing code" rule apply here?

[Nico, 2013-09-25 21:19:39]

Thanks for looking!

https://codereview.chromium.org/24649002/diff/16001/chrome/renderer/media/chr...
File chrome/renderer/media/chrome_key_systems.cc (right):

https://codereview.chromium.org/24649002/diff/16001/chrome/renderer/media/chr...
chrome/renderer/media/chrome_key_systems.cc:39: #endif  //
defined(USE_PROPRIETARY_CODECS)
On 2013/09/25 21:16:52, xhwang wrote:
> Are dropping "static" because it's static by default?

Yes.

> At lease in media/ code we
> still specify "static" all over the place. Shall the "be consistent with
> existing code" rule apply here?

I can revert it if you want, but I think there's value in global consistency in
the chromium codebase too. Your call.

[xhwang, 2013-09-25 21:21:30]

lgtm

https://codereview.chromium.org/24649002/diff/16001/chrome/renderer/media/chr...
File chrome/renderer/media/chrome_key_systems.cc (right):

https://codereview.chromium.org/24649002/diff/16001/chrome/renderer/media/chr...
chrome/renderer/media/chrome_key_systems.cc:39: #endif  //
defined(USE_PROPRIETARY_CODECS)
On 2013/09/25 21:19:41, Nico wrote:
> On 2013/09/25 21:16:52, xhwang wrote:
> > Are dropping "static" because it's static by default?
> 
> Yes.
> 
> > At lease in media/ code we
> > still specify "static" all over the place. Shall the "be consistent with
> > existing code" rule apply here?
> 
> I can revert it if you want, but I think there's value in global consistency
in
> the chromium codebase too. Your call.

sgtm if the chromium codebase is already doing this. We'll convert media/ to
chromium style gradually.

[xhwang, 2013-09-25 21:21:53]

media lgtm

[jamesr, 2013-09-25 21:34:38]

webkit/ lgtm
cc/ not lgtm

https://codereview.chromium.org/24649002/diff/16001/cc/trees/thread_proxy.cc
File cc/trees/thread_proxy.cc (left):

https://codereview.chromium.org/24649002/diff/16001/cc/trees/thread_proxy.cc#...
cc/trees/thread_proxy.cc:25: namespace {
why remove the namespace? now the constants are in the global namespace, which
seems like a really bad idea.  at least add 'static'

[Nico, 2013-09-25 21:36:25]

https://codereview.chromium.org/24649002/diff/16001/cc/trees/thread_proxy.cc
File cc/trees/thread_proxy.cc (left):

https://codereview.chromium.org/24649002/diff/16001/cc/trees/thread_proxy.cc#...
cc/trees/thread_proxy.cc:25: namespace {
On 2013/09/25 21:34:40, jamesr wrote:
> why remove the namespace? now the constants are in the global namespace, which
> seems like a really bad idea.  at least add 'static'

const has implicit internal linkage. The namespace and 'static' do nothing.

[Ilya Sherman, 2013-09-25 21:42:51]

//components/autofill lgtm

[jamesr, 2013-09-25 21:51:36]

cc/ lgtm

[Jói, 2013-09-25 21:58:55]

//components and //google_apis LGTM.

Now on my TODO list: Add to //google_apis/OWNERS.

[Nico, 2013-09-25 22:34:22]

Committed patchset #3 manually as r225273.

[piman, 2013-09-25 22:57:15]

lgtm