Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Side by Side Diff: chrome/common/omaha_query_params/omaha_query_params.cc

Issue 24649002: Clean up a few more unused globals. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: mac Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome/common/external_ipc_fuzzer.cc ('k') | chrome/renderer/media/chrome_key_systems.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/common/omaha_query_params/omaha_query_params.h" 5 #include "chrome/common/omaha_query_params/omaha_query_params.h"
6 6
7 #include "base/compiler_specific.h" 7 #include "base/compiler_specific.h"
8 #include "base/strings/stringprintf.h" 8 #include "base/strings/stringprintf.h"
9 #include "base/win/windows_version.h" 9 #include "base/win/windows_version.h"
10 #include "chrome/common/chrome_version_info.h" 10 #include "chrome/common/chrome_version_info.h"
(...skipping 28 matching lines...) Expand all
39 "x86"; 39 "x86";
40 #elif defined(__arm__) 40 #elif defined(__arm__)
41 "arm"; 41 "arm";
42 #elif defined(__mips__) 42 #elif defined(__mips__)
43 "mipsel"; 43 "mipsel";
44 #else 44 #else
45 #error "unknown arch" 45 #error "unknown arch"
46 #endif 46 #endif
47 47
48 const char kChrome[] = "chrome"; 48 const char kChrome[] = "chrome";
49 const char kChromeCrx[] = "chromecrx";
50 const char kChromiumCrx[] = "chromiumcrx"; 49 const char kChromiumCrx[] = "chromiumcrx";
51 50
52 const char kStable[] = "stable"; 51 const char kStable[] = "stable";
53 const char kBeta[] = "beta"; 52 const char kBeta[] = "beta";
54 const char kDev[] = "dev"; 53 const char kDev[] = "dev";
55 const char kCanary[] = "canary"; 54 const char kCanary[] = "canary";
56 55
56 #if defined(GOOGLE_CHROME_BUILD)
57 const char kChromeCrx[] = "chromecrx";
Lei Zhang 2013/09/25 20:26:01 shouldn't kChromiumCrx be the else case?
Nico 2013/09/25 20:42:25 Good point, done.
58 #endif // defined(GOOGLE_CHROME_BUILD)
59
57 } // namespace 60 } // namespace
58 61
59 namespace chrome { 62 namespace chrome {
60 63
61 // static 64 // static
62 std::string OmahaQueryParams::Get(ProdId prod) { 65 std::string OmahaQueryParams::Get(ProdId prod) {
63 return base::StringPrintf( 66 return base::StringPrintf(
64 "os=%s&arch=%s&nacl_arch=%s&prod=%s&prodchannel=%s&prodversion=%s", 67 "os=%s&arch=%s&nacl_arch=%s&prod=%s&prodchannel=%s&prodversion=%s",
65 kOs, 68 kOs,
66 kArch, 69 kArch,
(...skipping 69 matching lines...) Expand 10 before | Expand all | Expand 10 after
136 return kCanary; 139 return kCanary;
137 break; 140 break;
138 case chrome::VersionInfo::CHANNEL_UNKNOWN: 141 case chrome::VersionInfo::CHANNEL_UNKNOWN:
139 return kUnknown; 142 return kUnknown;
140 break; 143 break;
141 } 144 }
142 return kUnknown; 145 return kUnknown;
143 } 146 }
144 147
145 } // namespace chrome 148 } // namespace chrome
OLDNEW
« no previous file with comments | « chrome/common/external_ipc_fuzzer.cc ('k') | chrome/renderer/media/chrome_key_systems.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698