Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(685)

Unified Diff: xfa/fwl/core/cfwl_picturebox.cpp

Issue 2464703006: Fold IFWL*::{Initialize|Finalize} into constructor/destructor (Closed)
Patch Set: Rebase to master Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « xfa/fwl/core/cfwl_listbox.cpp ('k') | xfa/fwl/core/cfwl_pushbutton.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: xfa/fwl/core/cfwl_picturebox.cpp
diff --git a/xfa/fwl/core/cfwl_picturebox.cpp b/xfa/fwl/core/cfwl_picturebox.cpp
index 51f9d77ca1056522b98b292c2138f701377dd1a9..dcd716ca021cf32f21c23edcf27ce85c8f2cc7d3 100644
--- a/xfa/fwl/core/cfwl_picturebox.cpp
+++ b/xfa/fwl/core/cfwl_picturebox.cpp
@@ -8,6 +8,8 @@
#include <memory>
+#include "third_party/base/ptr_util.h"
+
CFWL_PictureBox::CFWL_PictureBox(const IFWL_App* app) : CFWL_Widget(app) {}
CFWL_PictureBox::~CFWL_PictureBox() {}
@@ -15,11 +17,9 @@ CFWL_PictureBox::~CFWL_PictureBox() {}
void CFWL_PictureBox::Initialize() {
ASSERT(!m_pIface);
- std::unique_ptr<IFWL_PictureBox> pPictureBox(new IFWL_PictureBox(
- m_pApp, m_pProperties->MakeWidgetImpProperties(&m_PictureBoxDP)));
- pPictureBox->Initialize();
+ m_pIface = pdfium::MakeUnique<IFWL_PictureBox>(
+ m_pApp, m_pProperties->MakeWidgetImpProperties(&m_PictureBoxDP));
- m_pIface = std::move(pPictureBox);
CFWL_Widget::Initialize();
}
« no previous file with comments | « xfa/fwl/core/cfwl_listbox.cpp ('k') | xfa/fwl/core/cfwl_pushbutton.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698