Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(266)

Unified Diff: xfa/fwl/core/cfwl_listbox.cpp

Issue 2464703006: Fold IFWL*::{Initialize|Finalize} into constructor/destructor (Closed)
Patch Set: Rebase to master Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « xfa/fwl/core/cfwl_edit.cpp ('k') | xfa/fwl/core/cfwl_picturebox.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: xfa/fwl/core/cfwl_listbox.cpp
diff --git a/xfa/fwl/core/cfwl_listbox.cpp b/xfa/fwl/core/cfwl_listbox.cpp
index 139c488830e651016ad0145d838dd09a0074d97b..800dd2e570d01cbf0d57d727602a6ff3c1b07b13 100644
--- a/xfa/fwl/core/cfwl_listbox.cpp
+++ b/xfa/fwl/core/cfwl_listbox.cpp
@@ -8,6 +8,7 @@
#include <memory>
+#include "third_party/base/ptr_util.h"
#include "third_party/base/stl_util.h"
namespace {
@@ -25,11 +26,9 @@ CFWL_ListBox::~CFWL_ListBox() {}
void CFWL_ListBox::Initialize() {
ASSERT(!m_pIface);
- std::unique_ptr<IFWL_ListBox> pListBox(new IFWL_ListBox(
- m_pApp, m_pProperties->MakeWidgetImpProperties(&m_ListBoxDP), nullptr));
- pListBox->Initialize();
+ m_pIface = pdfium::MakeUnique<IFWL_ListBox>(
+ m_pApp, m_pProperties->MakeWidgetImpProperties(&m_ListBoxDP), nullptr);
- m_pIface = std::move(pListBox);
CFWL_Widget::Initialize();
}
« no previous file with comments | « xfa/fwl/core/cfwl_edit.cpp ('k') | xfa/fwl/core/cfwl_picturebox.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698