Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(821)

Issue 2464663002: chrome: move networking_private_crypto from common to browser (Closed)

Created:
4 years, 1 month ago by tfarina
Modified:
4 years, 1 month ago
Reviewers:
Lei Zhang
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, mac-reviews_chromium.org, stevenjb+watch_chromium.org, extensions-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

chrome: move networking_private_crypto from common to browser It has no dependencies on common and it is only used by browser, so it can live there now. BUG=None R=thestig@chromium.org Committed: https://crrev.com/e3f8d5237fd1d2319a1b883c1fc3f53fbe5b0be7 Cr-Commit-Position: refs/heads/master@{#428624}

Patch Set 1 #

Patch Set 2 : chrome/test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -498 lines) Patch
M chrome/browser/extensions/BUILD.gn View 1 chunk +10 lines, -0 lines 0 comments Download
M chrome/browser/extensions/api/networking_private/crypto_verify_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/networking_private/networking_private_credentials_getter_mac.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/networking_private/networking_private_credentials_getter_win.cc View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/extensions/api/networking_private/networking_private_crypto.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/extensions/api/networking_private/networking_private_crypto.cc View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/extensions/api/networking_private/networking_private_crypto_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/BUILD.gn View 1 chunk +0 lines, -9 lines 0 comments Download
D chrome/common/extensions/api/networking_private/networking_private_crypto.h View 1 chunk +0 lines, -61 lines 0 comments Download
D chrome/common/extensions/api/networking_private/networking_private_crypto.cc View 1 chunk +0 lines, -187 lines 0 comments Download
D chrome/common/extensions/api/networking_private/networking_private_crypto_unittest.cc View 1 chunk +0 lines, -231 lines 0 comments Download
M chrome/test/BUILD.gn View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/utility/extensions/extensions_handler.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 18 (13 generated)
Lei Zhang
lgtm
4 years, 1 month ago (2016-10-30 04:05:04 UTC) #10
Lei Zhang
Fixed typo in commit message.
4 years, 1 month ago (2016-10-30 04:06:08 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2464663002/20001
4 years, 1 month ago (2016-10-30 11:27:15 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-10-30 11:32:49 UTC) #16
commit-bot: I haz the power
4 years, 1 month ago (2016-10-30 11:35:01 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e3f8d5237fd1d2319a1b883c1fc3f53fbe5b0be7
Cr-Commit-Position: refs/heads/master@{#428624}

Powered by Google App Engine
This is Rietveld 408576698