Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(839)

Issue 2464613002: Update remoting_perftest to evaluate bandwidth estimation. (Closed)

Created:
4 years, 1 month ago by Sergey Ulanov
Modified:
4 years, 1 month ago
Reviewers:
Jamie
CC:
chromium-reviews, chromoting-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update remoting_perftest to evaluate bandwidth estimation. Following changes will allow to validate bugfixes in BWE logic in WebRTC. 1. Added new cases in ProtocolPerftest to simulate signaling delay. 2. Tests report bandwidth estimate now. Also removed NOTIMPLEMENTED() in remoting/test/fake_socket_factory.cc to avoid noise in the logs. Committed: https://crrev.com/6e555c42ff5382d80f9c41a2ff40ffca4ef8af9e Cr-Commit-Position: refs/heads/master@{#428817}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -28 lines) Patch
M remoting/test/fake_socket_factory.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M remoting/test/protocol_perftest.cc View 10 chunks +64 lines, -26 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 11 (6 generated)
Sergey Ulanov
4 years, 1 month ago (2016-10-29 07:06:42 UTC) #4
Jamie
lgtm
4 years, 1 month ago (2016-10-31 18:07:29 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2464613002/1
4 years, 1 month ago (2016-10-31 20:42:43 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-31 21:24:24 UTC) #9
commit-bot: I haz the power
4 years, 1 month ago (2016-10-31 21:27:00 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6e555c42ff5382d80f9c41a2ff40ffca4ef8af9e
Cr-Commit-Position: refs/heads/master@{#428817}

Powered by Google App Engine
This is Rietveld 408576698