Bugfixes in JingleSession

Bugfixes in JingleSession

1. Previously JingleSession didn't allow transport-info messages in
   AUTHENTICATING state. Problem is that authentication messages may be
   processed asynchronously, so potentially transport-info may be
   received in AUTHENTICATING state even if the peer sends it in
   AUTHENTICATED state. Now transport-info messages are queued until
   authentication is finished. In future this may also allow to start
   transport handshake before authentication is finished.
2. Message reordering logic wasn't handling the case when the session
   is destroyed after one of the reordered messages. Fixed it and added
   test.
3. Other minor fixes: replaced std::set<> and std::list<> with
   std::vector<> for message queues, made PendingMessage movable.

Committed: https://crrev.com/04e7784ab645b42a30304cf515efd694dddc2ba0
Cr-Commit-Position: refs/heads/master@{#428768}

[Sergey Ulanov, 2016-10-29 06:59:01]

Description was changed from

==========
Bugfixes in JingleSession

1. Previously JingleSession didn't allow transport-info messages in
   AUTHENTICATING state. Problem is that authentication messages may be
   processed asynchronously, so potentially transport-info may be
   received in AUTHENTICATING state even if the peer sends it in
   AUTHENTICATED state. Now transport-info messages are queued until
   authentication is finished. In future this may also allow to start
   transport handshake before authentication is finished.
2. Message reordering logic wasn't handling the case when the session
   is destroyed after one of the reordered messages. Fixed it and added
   test.
3. Other minor fixes: replaced std::set<> and std::list<> with
   std::vector<> for message queues, as it should be more efficient.
==========

to

==========
Bugfixes in JingleSession

1. Previously JingleSession didn't allow transport-info messages in
   AUTHENTICATING state. Problem is that authentication messages may be
   processed asynchronously, so potentially transport-info may be
   received in AUTHENTICATING state even if the peer sends it in
   AUTHENTICATED state. Now transport-info messages are queued until
   authentication is finished. In future this may also allow to start
   transport handshake before authentication is finished.
2. Message reordering logic wasn't handling the case when the session
   is destroyed after one of the reordered messages. Fixed it and added
   test.
3. Other minor fixes: replaced std::set<> and std::list<> with
   std::vector<> for message queues, made PendingMessage movable.
==========

[Sergey Ulanov, 2016-10-29 06:59:10]

sergeyu@chromium.org changed reviewers:
+ kelvinp@chromium.org

[kelvinp, 2016-10-31 18:23:14]

lgtm

https://codereview.chromium.org/2453933008/diff/1/remoting/protocol/jingle_se...
File remoting/protocol/jingle_session.cc (right):

https://codereview.chromium.org/2453933008/diff/1/remoting/protocol/jingle_se...
remoting/protocol/jingle_session.cc:160:
JingleSession::PendingMessage::PendingMessage() = default;
Out of curiosity, why is a default empty constructor needed?

[Sergey Ulanov, 2016-10-31 18:25:02]

https://codereview.chromium.org/2453933008/diff/1/remoting/protocol/jingle_se...
File remoting/protocol/jingle_session.cc (right):

https://codereview.chromium.org/2453933008/diff/1/remoting/protocol/jingle_se...
remoting/protocol/jingle_session.cc:160:
JingleSession::PendingMessage::PendingMessage() = default;
On 2016/10/31 18:23:14, kelvinp wrote:
> Out of curiosity, why is a default empty constructor needed?

std::vector<> needs it.

[Sergey Ulanov, 2016-10-31 18:25:32]

The CQ bit was checked by sergeyu@chromium.org

[commit-bot: I haz the power, 2016-10-31 18:25:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-31 19:29:34]

Description was changed from

==========
Bugfixes in JingleSession

1. Previously JingleSession didn't allow transport-info messages in
   AUTHENTICATING state. Problem is that authentication messages may be
   processed asynchronously, so potentially transport-info may be
   received in AUTHENTICATING state even if the peer sends it in
   AUTHENTICATED state. Now transport-info messages are queued until
   authentication is finished. In future this may also allow to start
   transport handshake before authentication is finished.
2. Message reordering logic wasn't handling the case when the session
   is destroyed after one of the reordered messages. Fixed it and added
   test.
3. Other minor fixes: replaced std::set<> and std::list<> with
   std::vector<> for message queues, made PendingMessage movable.
==========

to

==========
Bugfixes in JingleSession

1. Previously JingleSession didn't allow transport-info messages in
   AUTHENTICATING state. Problem is that authentication messages may be
   processed asynchronously, so potentially transport-info may be
   received in AUTHENTICATING state even if the peer sends it in
   AUTHENTICATED state. Now transport-info messages are queued until
   authentication is finished. In future this may also allow to start
   transport handshake before authentication is finished.
2. Message reordering logic wasn't handling the case when the session
   is destroyed after one of the reordered messages. Fixed it and added
   test.
3. Other minor fixes: replaced std::set<> and std::list<> with
   std::vector<> for message queues, made PendingMessage movable.
==========

[commit-bot: I haz the power, 2016-10-31 19:29:39]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-10-31 19:49:32]

Description was changed from

==========
Bugfixes in JingleSession

1. Previously JingleSession didn't allow transport-info messages in
   AUTHENTICATING state. Problem is that authentication messages may be
   processed asynchronously, so potentially transport-info may be
   received in AUTHENTICATING state even if the peer sends it in
   AUTHENTICATED state. Now transport-info messages are queued until
   authentication is finished. In future this may also allow to start
   transport handshake before authentication is finished.
2. Message reordering logic wasn't handling the case when the session
   is destroyed after one of the reordered messages. Fixed it and added
   test.
3. Other minor fixes: replaced std::set<> and std::list<> with
   std::vector<> for message queues, made PendingMessage movable.
==========

to

==========
Bugfixes in JingleSession

1. Previously JingleSession didn't allow transport-info messages in
   AUTHENTICATING state. Problem is that authentication messages may be
   processed asynchronously, so potentially transport-info may be
   received in AUTHENTICATING state even if the peer sends it in
   AUTHENTICATED state. Now transport-info messages are queued until
   authentication is finished. In future this may also allow to start
   transport handshake before authentication is finished.
2. Message reordering logic wasn't handling the case when the session
   is destroyed after one of the reordered messages. Fixed it and added
   test.
3. Other minor fixes: replaced std::set<> and std::list<> with
   std::vector<> for message queues, made PendingMessage movable.

Committed: https://crrev.com/04e7784ab645b42a30304cf515efd694dddc2ba0
Cr-Commit-Position: refs/heads/master@{#428768}
==========

[commit-bot: I haz the power, 2016-10-31 19:49:33]

Patchset 1 (id:??) landed as
https://crrev.com/04e7784ab645b42a30304cf515efd694dddc2ba0
Cr-Commit-Position: refs/heads/master@{#428768}